Date: Tue, 9 Apr 2002 09:17:49 +0200 (CEST) From: Nick Hibma <n_hibma@van-laarhoven.org> To: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> Cc: Josef Karthauser <joe@tao.org.uk>, Hidetoshi Shimokawa <simokawa@FreeBSD.org>, "cvs-committers@FreeBSD.org" <cvs-committers@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c scsi_da.c Message-ID: <20020409091528.Q374-100000@heather.van-laarhoven.org> In-Reply-To: <ybswuviqt59.wl@ett.sat.t.u-tokyo.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
The umass driver returns the error just fine. See many postings on this in the appropriate mailing lists. The correct thing to do is to pass up the NO_6_BYTE_COMMANDS quirk from the driver to the CAM layer. At the moment the 6 byte commands are converted inside the umass driver to their 10 byte equivalents, so there should be no need for your patch in the first place (apart from the T_RBC bits of course, which looks like a good thing to me). Nick On Mon, 8 Apr 2002, Hidetoshi Shimokawa wrote: > At Mon, 8 Apr 2002 10:55:21 +0100, > Josef Karthauser wrote: > > > > On Mon, Apr 08, 2002 at 01:44:16AM -0700, Hidetoshi Shimokawa wrote: > > > simokawa 2002/04/08 01:44:16 PDT > > > > > > Modified files: (Branch: RELENG_4) > > > sys/cam/scsi scsi_all.c scsi_da.c > > > Log: > > > MFC: > > > - Add support for Simplified Direct Access Device. > > > - Automatically detect devices that do not support READ(6)/WRITE(6). > > > > > > scsi_all.c: rev. 1.29 > > > scsi_da.c: rev. 1.98, 1.101 > > > > Does this mean that the usb umass quirks can be removed? > > If the device returns SCSI error (illegal request), > it can be removed. But if it returns no error, you have to do > sysctl kern.cam.da.no_6_byte=1 or keep the quirks or > enable ad-hoc workaround (the follwing patch). > Justin ask me to disable this part until he looks into the umass-sim. > > As far as I know umass-sim doesn't return any error for the > most of the drives. I think umass-sim should be return some errors > if tranfer length is 0. > > > /\ Hidetoshi Shimokawa > \/ simokawa@sat.t.u-tokyo.ac.jp > PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html > > > Index: scsi_da.c > =================================================================== > RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v > retrieving revision 1.102 > diff -u -r1.102 scsi_da.c > --- scsi_da.c 31 Mar 2002 22:28:03 -0000 1.102 > +++ scsi_da.c 8 Apr 2002 12:16:35 -0000 > @@ -1402,7 +1402,7 @@ > bp->bio_error = 0; > if (bp->bio_resid != 0) { > /* Short transfer ??? */ > -#if 0 > +#if 1 > if (cmd6workaround(done_ccb) > == ERESTART) > return; > @@ -1422,7 +1422,7 @@ > bp->bio_resid = csio->resid; > if (csio->resid > 0) { > /* Short transfer ??? */ > -#if 0 /* XXX most of the broken umass devices need this ad-hoc work around */ > +#if 1 /* XXX most of the broken umass devices need this ad-hoc work around */ > if (cmd6workaround(done_ccb) == ERESTART) > return; > #endif > > > -- n_hibma@van-laarhoven.org http://www.van-laarhoven.org/ n_hibma@FreeBSD.org http://www.etla.net/~n_hibma/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020409091528.Q374-100000>