Date: Mon, 15 Sep 2014 12:29:50 -0400 From: Adam Weinberger <adamw@adamw.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org>, jadm <jadm@dachev.info>, "Vanilla I. Shu" <vanilla@freebsd.org> Subject: Re: svn commit: r368241 - in head/sysutils: . jadm jadm/files Message-ID: <3A4A31F5-EADB-4B23-97D4-15368CCC9752@adamw.org> In-Reply-To: <CAJE75NEfS2=iExysLF_oPFtkQ1tE3GOZXu-rwN4-6i3wGtnhCw@mail.gmail.com> References: <201409150227.s8F2ReuH083121@svn.freebsd.org> <CAJE75NE1p_mf4xHADQgoeKnmk_E7Wej9pfTsGJnPsJOj4PHWcw@mail.gmail.com> <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org> <CAJE75NEfS2=iExysLF_oPFtkQ1tE3GOZXu-rwN4-6i3wGtnhCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Sep, 2014, at 12:05, Jason E. Hale <jhale@freebsd.org> wrote:
> On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger <adamw@adamw.org> =
wrote:
>> On 15 Sep, 2014, at 3:50, Jason E. Hale <jhale@FreeBSD.org> wrote:
>>=20
>>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu =
<vanilla@freebsd.org> wrote:
>>>>=20
>>>> +BUILD_DEPENDS=3D =
${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko =
\
>>>> + =
${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces =
\
>>>> + =
${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate =
\
>>>> + =
${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress
>>>=20
>>> This is a deprecated style of depending on other Python ports.
>>> Format should be:
>>> BUILD_DEPENDS=3D =
${PYTHON_PKGNAMEPREFIX}paramiko>=3D0:${PORTSDIR}/security/py-paramiko
>>=20
>> I had no idea that format was deprecated. Perhaps an example could be =
added to the PHB or Uses/python.mk?
>>=20
> I'm sure the Python section of the PHB could use some attention. It
> still references the old USE_PYTHON and
> bsd.python.mk instead of USES=3Dpython and Uses/python.mk among other =
things.
>=20
> The format I mentioned is the one I have seen in most Python and Perl
> ports, however, Uses/python.mk has a mix
> of both styles. I guess "deprecated" was a little strong, that's more
> of an official word. "Not so common" might be
> more appropriate. To me, it looks cleaner and allows for version
> checking. Even still, ${PYTHON_SITELIBDIR}
> would be preferable to ${PYTHON_LIBDIR}/site-packages.
No I totally agree with you. It=92d just be really nice if you could =
count on the PHB being full of examples of best-practice.
The funny thing is, each thing that you mentioned in your original =
message to Vanilla (LICENSE_FILE, PYTHON_PKGNAMEPREFIX, OPSYS, and not =
using ${CP})... none of those things are spelled out in the PHB.
I would think that the vast majority of the PHB should be like Section =
6... a big list of =93Using xyz=94. Alphabetize it, and every time =
somebody wants to know how to do x, they just jump to that section. =
Right now, there is essentially no structure.
I especially love that the sample Makefile demonstrates an interactive =
port, clobbers variables, uses sets EXTRACT_SUFX manually, and contains =
more filler text than code. The sample makefile should be =
self-documenting, and should be a proper set of real-world uses that =
people can look at as a positive reference.
</soapbox>
# Adam
--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A4A31F5-EADB-4B23-97D4-15368CCC9752>