Date: Mon, 12 Jan 2015 17:55:15 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Alexander V. Chernikov" <melifaro@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276844 - head/sys/netinet6 Message-ID: <20150112145515.GN15484@FreeBSD.org> In-Reply-To: <201501081802.t08I26nA010368@svn.freebsd.org> References: <201501081802.t08I26nA010368@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 08, 2015 at 06:02:06PM +0000, Alexander V. Chernikov wrote: A> Author: melifaro A> Date: Thu Jan 8 18:02:05 2015 A> New Revision: 276844 A> URL: https://svnweb.freebsd.org/changeset/base/276844 A> A> Log: A> * Use newly-created nd6_grab_holdchain() function to retrieve lle A> hold mbuf chain instead of calling full-blown nd6_output_lle() A> for each packet. This simplifies both callers and nd6_output_lle() A> implementation. A> * Make nd6_output_lle() static and remove now-unused lle and chain A> arguments. A> * Rename nd6_output_flush() -> nd6_flush_holdchain() to be consistent. A> * Move all pre-send transmit hooks to newly-created nd6_output_ifp(). A> Now nd6_output(), nd6_output_lle() and nd6_flush_holdchain() are using A> it to send mbufs to if_output. A> * Remove SeND hook from nd6_na_input() because it was implemented A> incorrectly since the beginning (r211501): A> - it tagged initial input mbuf (m) instead of m_hold A> - tagging _all_ mbufs in holdchain seems to be wrong anyway. Thanks that you gathered into one place all instances of ifp->if_output(origifp, ... ^^^ ^^^^^^^ But this extremely ugly place still needs to be fixed :) -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150112145515.GN15484>