From owner-svn-ports-head@freebsd.org  Mon Apr 24 19:02:01 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 275B4D4DB8B;
 Mon, 24 Apr 2017 19:02:01 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B802D1F30;
 Mon, 24 Apr 2017 19:02:00 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id e096d555
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Mon, 24 Apr 2017 13:01:53 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r439336 - head/Tools/scripts
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <1ssh-eirz-wny@FreeBSD.org>
Date: Mon, 24 Apr 2017 13:01:51 -0600
Cc: Emanuel Haupt <ehaupt@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <70CC3905-8A7E-41C7-A45F-5D4CC5BBECB9@adamw.org>
References: <201704241727.v3OHRwXA083890@repo.freebsd.org>
 <1ssh-eirz-wny@FreeBSD.org>
To: Jan Beich <jbeich@FreeBSD.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 19:02:01 -0000

> On 24 Apr, 2017, at 12:56, Jan Beich <jbeich@FreeBSD.org> wrote:
>=20
> Emanuel Haupt <ehaupt@FreeBSD.org> writes:
>=20
>> Author: ehaupt
>> Date: Mon Apr 24 17:27:58 2017
>> New Revision: 439336
>> URL: https://svnweb.freebsd.org/changeset/ports/439336
>>=20
>> Log:
>>  Fix shebang. If /usr/bin/env is used the -w flag can't be passed =
after perl.
>>  Use 'use warnings;' instead.
> [...]
>> -#!/usr/bin/env perl -w
>> +#!/usr/bin/env perl
>=20
> Why not use -S ? Tools/scripts/ are unlikely to be run on non-FreeBSD.
>=20
>  #!/usr/bin/env -S perl -w
>=20
> https://svnweb.freebsd.org/changeset/base/147493

The "warnings" pragma is preferred over the "-w" switch anyway. See =
https://perldoc.perl.org/warnings.html#What's-wrong-with-*-w*-and-%24%5eW

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org