Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Apr 2003 13:37:08 -0400
From:      Andrew Gallatin <gallatin@cs.duke.edu>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
Message-ID:  <20030429133708.A84234@grasshopper.cs.duke.edu>
In-Reply-To: <200304290545.h3T5j99Y076513@repoman.freebsd.org>; from imp@FreeBSD.org on Mon, Apr 28, 2003 at 10:45:09PM -0700
References:  <200304290545.h3T5j99Y076513@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh [imp@FreeBSD.org] wrote:
>           2) Call FXP_UNLOCK() before calling bus_teardown_intr to avoid
>              a possible deadlock reported by jhb.
>           3) add gone to the softc.  Set it to true in detach.

>           5) Return immediately if gone is true in fxp_intr
>   

My workstation has been up for ~5 hours now, and has seen 1.3 million 
fxp interrupts.  That's 1.3 million extra compares that this code
is now executing.

What is this deadlock with bus_teardown_intr?  Could we possibly fix
this some other way than by adding (mostly) useless code to the
critical path? 

Drew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030429133708.A84234>