From owner-cvs-src@FreeBSD.ORG  Fri Jun  4 14:08:46 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 013C516A4CE; Fri,  4 Jun 2004 14:08:46 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EAE4143D1D; Fri,  4 Jun 2004 14:08:45 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 38F875C860; Fri,  4 Jun 2004 14:08:41 -0700 (PDT)
Date: Fri, 4 Jun 2004 23:08:41 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Kris Kennaway <kris@obsecurity.org>
Message-ID: <20040604210841.GL9228@elvis.mu.org>
References: <200406022252.i52MqJFp094240@repoman.freebsd.org>
	<20040603011904.GB714@xor.obsecurity.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040603011904.GB714@xor.obsecurity.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2004 21:08:46 -0000

Kris Kennaway wrote:
> On Wed, Jun 02, 2004 at 03:52:18PM -0700, Maxime Henrion wrote:
> > mux         2004/06/02 15:52:18 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/fxp          if_fxp.c if_fxpvar.h 
> >   Log:
> >   Use the device sysctl tree instead of rolling our own.  Some of the
> >   sysctls were global (hw.fxp_rnr and hw.fxp_noflow), all of them are
> >   now per-device.  Sample output of "sysctl dev.fxp0" with this patch,
> >   with the standard %foo nodes removed :
> >   
> >   dev.fxp0.int_delay: 1000
> >   dev.fxp0.bundle_max: 6
> >   dev.fxp0.rnr: 0
> >   dev.fxp0.noflow: 0
> 
> What are your thoughts about making noflow the default?  Having an fxp
> machine panic and DoS an entire network is not friendly.

I'm not opposed to that.  I'd like to hear rwatson confirming this since
he's the one who implemented that sysctl, but I think it is fairly safe.  

Cheers,
Maxime