From owner-freebsd-fs@FreeBSD.ORG Mon Feb 6 13:04:22 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49797106566C; Mon, 6 Feb 2012 13:04:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id AF55E8FC13; Mon, 6 Feb 2012 13:04:21 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q16D4Eu6049595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 6 Feb 2012 15:04:14 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q16D4Ee9087784; Mon, 6 Feb 2012 15:04:14 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q16D4ErW087783; Mon, 6 Feb 2012 15:04:14 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 6 Feb 2012 15:04:14 +0200 From: Konstantin Belousov To: Martin Matuska Message-ID: <20120206130414.GS3283@deviant.kiev.zoral.com.ua> References: <4F2F9CB9.3040000@FreeBSD.org> <20120206123613.GR3283@deviant.kiev.zoral.com.ua> <4F2FCEE6.1080400@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8H2h1WtNxqGVRR8A" Content-Disposition: inline In-Reply-To: <4F2FCEE6.1080400@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: [CFR][DEVFS] Add "ruleset" mount option X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 13:04:22 -0000 --8H2h1WtNxqGVRR8A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 06, 2012 at 02:00:22PM +0100, Martin Matuska wrote: > On 6. 2. 2012 13:36, Konstantin Belousov wrote: > > On Mon, Feb 06, 2012 at 10:26:17AM +0100, Martin Matuska wrote: > >> The devfs(8) command supports configuring specific rulesets for devfs(= 5) > >> mounts. > >> However, it operates on already mounted devfs filesystems only and it = is > >> impossible to configure a specific ruleset on mount-time. > >> > >> The attached patch adds a "ruleset" mount option to devfs mounts. > >> The ruleset is automatically applied upon mount time. If the ruleset > >> doesn't exist, an empty ruleset with the given numer is created and > >> can be modified with devfs(8) later. > >> > >> The patch is also available at: > >> http://people.freebsd.org/~mm/patches/devfs/devfs_mount_ruleset.patch > >> > >> Please review and/or comment my attached patch. > >> > > Did you tested this with witness turned on ? It seems not. > Yes, I did, no warnings or error messages on my console. Are you sure ? Did you tried to change rulesets after mounting some devfs with ruleset option ? =46rom what I see, sx_rules is after dm_lock, e.g. in devfs_rules_ioctl(), while your patch insists on reversed order. --8H2h1WtNxqGVRR8A Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk8vz80ACgkQC3+MBN1Mb4i+KgCfcgdZL8oph+GjHsjy5qZt2mP6 JUUAoKaS7y2sQZxZIJl5vWI6HSCMohab =bloM -----END PGP SIGNATURE----- --8H2h1WtNxqGVRR8A--