From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 22 14:50:19 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3AA5D16A405 for ; Mon, 22 Jan 2007 14:50:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 0218A13C47E for ; Mon, 22 Jan 2007 14:50:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l0MEoI6E057266 for ; Mon, 22 Jan 2007 14:50:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l0MEoImf057265; Mon, 22 Jan 2007 14:50:18 GMT (envelope-from gnats) Resent-Date: Mon, 22 Jan 2007 14:50:18 GMT Resent-Message-Id: <200701221450.l0MEoImf057265@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yong Tang Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C86216A405 for ; Mon, 22 Jan 2007 14:45:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id 1C11213C4C3 for ; Mon, 22 Jan 2007 14:45:28 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0MEjRSD090792 for ; Mon, 22 Jan 2007 14:45:27 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l0MEjRFA090791; Mon, 22 Jan 2007 14:45:27 GMT (envelope-from nobody) Message-Id: <200701221445.l0MEjRFA090791@www.freebsd.org> Date: Mon, 22 Jan 2007 14:45:27 GMT From: Yong Tang To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: misc/108211: potentially a bug for inet_aton in sys/netinet/libalias/alias_proxy.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 14:50:19 -0000 >Number: 108211 >Category: misc >Synopsis: potentially a bug for inet_aton in sys/netinet/libalias/alias_proxy.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 22 14:50:18 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Yong Tang >Release: 6.1 >Organization: Sunbelt Software >Environment: >Description: In sys/netinet/libalias/alias_proxy.c, The following code exist. 158 #ifdef _KERNEL 159 static int 160 inet_aton(cp, addr) 161 const char *cp; 162 struct in_addr *addr; 163 { 180 l = strtoul(c, &endptr, 0); 181 182 if (l == ULONG_MAX || l == 0) 183 return (0); However, if the input cp is "0.0.0.0", then it seems this function will return (0) which is considered as an error. The reason is because 180: l = strtoul(c, &endptr, 0); l will return a 0 when the c is "0". Not quite sure if this is done purposely in FreeBSD but I have never experience similiar cases in other unix-platforms. Possible solution: change 182 (l == ULONG_MAX || l == 0) into 182 (l == ULONG_MAX || (l == 0 && (endptr == c)) >How-To-Repeat: review the code 180-182 in sys/netinet/libalias/alias_proxy.c >Fix: Possible solution: change 182 (l == ULONG_MAX || l == 0) into 182 (l == ULONG_MAX || (l == 0 && (endptr == c)) >Release-Note: >Audit-Trail: >Unformatted: