From owner-freebsd-audit  Sun Jun 18 23:15:51 2000
Delivered-To: freebsd-audit@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP id 6067137B979
	for <audit@freebsd.org>; Sun, 18 Jun 2000 23:15:49 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id AAA32637
	for <audit@freebsd.org>; Mon, 19 Jun 2000 00:15:48 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id AAA54318 for <audit@freebsd.org>; Mon, 19 Jun 2000 00:14:24 -0600 (MDT)
Message-Id: <200006190614.AAA54318@harmony.village.org>
To: audit@freebsd.org
Subject: Any reason not to do this?
Date: Mon, 19 Jun 2000 00:14:24 -0600
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


I don't see any reason for restore to be setgid tty.  What's wrong
with this patch:

This is inspired by OpenBSD's cleanup in this area.

Index: Makefile
===================================================================
RCS file: /home/imp/FreeBSD/CVS/src/sbin/restore/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	2000/02/24 21:01:54	1.13
+++ Makefile	2000/06/19 06:11:37
@@ -4,11 +4,8 @@
 PROG=	restore
 LINKS=	${BINDIR}/restore ${BINDIR}/rrestore
 CFLAGS+=-DRRESTORE
-CFLAGS+=-I${.CURDIR}/../../libexec/rlogind
 SRCS=	main.c interactive.c restore.c dirs.c symtab.c tape.c utilities.c \
 	dumprmt.c
-BINGRP=	tty
-BINMODE=2555
 MAN8=	restore.8
 MLINKS+=restore.8 rrestore.8
 .PATH:	${.CURDIR}/../dump


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message