From owner-cvs-all@FreeBSD.ORG Mon May 5 15:54:39 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E97B737B401 for ; Mon, 5 May 2003 15:54:34 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 7FEE743FE0 for ; Mon, 5 May 2003 15:54:33 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 5931 invoked by uid 1000); 5 May 2003 22:54:34 -0000 Date: Mon, 5 May 2003 15:54:34 -0700 (PDT) From: Nate Lawson To: Peter Jeremy In-Reply-To: <20030505202844.GA972@cirb503493.alcatel.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2003 22:54:41 -0000 On Tue, 6 May 2003, Peter Jeremy wrote: > On Fri, Apr 25, 2003 at 06:24:08PM -0700, Nate Lawson wrote: > >I have run various versions of the patch for about 3 weeks and the final > >version with no changes for about a week, all without Giant. The reason > >why I did not see ifnet problems even though I processed ~400M packets was > >because all ifnet processing happened to be with the fxp lock held and my > >laptop only had one network interface. This is not an intentional part of > >the patch; it is not an attempt to protect ifnet with a local fxp lock! > > What about the loopback interface (and maybe other virtual interfaces)? > Do you have lo0 disabled or does something else protect it? ifnet locking is the answer