From owner-svn-src-stable-11@freebsd.org Thu Feb 21 16:28:34 2019 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 412C414E6D73; Thu, 21 Feb 2019 16:28:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 978508206D; Thu, 21 Feb 2019 16:28:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x529.google.com with SMTP id i130so13939527pgd.1; Thu, 21 Feb 2019 08:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hZP6DDnvc540eJHBg8RcvyZ9Ogw09cukITCRskFEQU8=; b=eMh0i1qrXI4b+O5ap/M+PfhvH/1KWD95zF0ld/5Dx/WL4P0/kxD6o4e5dcevpVKs9C l+Du2/imm50VCC7S66xVSBZrhAryH2Ab6adare8JBGPTnecjmMmevhV7SW2e5hRaFAqs IvsNY4qIiPsUTV/5RTACSLNOYH/VPRw8mX9CMDysZRGi4a5Z9tZZABH34BWeFoYvvFjg Kx7Q1vRPvgz4BhTvldQtUEdi9Kmfv5VczWYLNzK2z+pJwJeRnGW/wl+IIcFkFAUFQ37m YBJVVUhFBL7Rl0JHUHBt5CaWeQSHsKsYvQaA1W2TM82q45sTZQ5LX64OVN3cYSrBnF7Y lKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hZP6DDnvc540eJHBg8RcvyZ9Ogw09cukITCRskFEQU8=; b=gQY5XoYc6WbN9GzqjRWuTlbQgaTypCZbaMc4jZb1dmA/P7sVhqwRs80VzAZAmfBC3S Vef6zoTN0GZXSmROjWMeIJO/cwtQaXcjPoHG5yhSt0g/z0GnoDMqewoEPyN634fD1wcg g+qutCXBqraSVQ2Bp3uwxwQVXE/Omvw00caKbwFSfd4ECyzu/+hey7MUibddETpTuR8v kRoACyIXJ4vswTFj9ka0DHLxH/SMZ1n15/2nEwZdhgcV37NjUnQhWOXzYv5K9BvsOHsk HFh5NsFCcSgx4dTSOn536qlWkTLLkvoCBRs18JPeZKKNlUETi371Xzguhp2kS7qOIt4b TMIQ== X-Gm-Message-State: AHQUAuZreanVXmXlCh3tOaR1wKT7jogV25V5H0L5gF06MUFXMNF+ks49 EA1DiDmcMUPiDZGHKuBSHi8sAsTL X-Google-Smtp-Source: AHgI3IbzIq1L6SaNeE7VRF68yGGqYYgf4oWHLlj0FV1feGjowXD8dqXK+03dBr15qim6TtigAyeucg== X-Received: by 2002:a62:11ca:: with SMTP id 71mr36864039pfr.18.1550766512078; Thu, 21 Feb 2019 08:28:32 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id k64sm45160840pfj.69.2019.02.21.08.28.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 08:28:31 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r344414 - stable/11 From: Enji Cooper X-Mailer: iPhone Mail (16D57) In-Reply-To: Date: Thu, 21 Feb 2019 08:28:30 -0800 Cc: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <6A8C488C-05F4-4607-8F40-F301AF91E7EA@gmail.com> References: <201902210322.x1L3MKeV007120@repo.freebsd.org> <201902210616.x1L6G7SV018721@pdx.rh.CN85.dnsmgr.net> To: Kyle Evans X-Rspamd-Queue-Id: 978508206D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.942,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 16:28:34 -0000 > On Feb 21, 2019, at 04:43, Kyle Evans wrote: >=20 > On Thu, Feb 21, 2019 at 12:16 AM Rodney W. Grimes > wrote: >>=20 >>> Author: kevans >>> Date: Thu Feb 21 03:22:20 2019 >>> New Revision: 344414 >>> URL: https://svnweb.freebsd.org/changeset/base/344414 >>>=20 >>> Log: >>> MFC (RECORD ONLY) r338050: Loader default interpreter flip >>>=20 >>> The default interpreter for stable/11 is 4th; this will never and can n= ever >>> change. Record MFC of r338050 to proactively prevent any accidents in f= uture >>> batching of MFCs. >>>=20 >>> Modified: >>> Directory Properties: >>> stable/11/ (props changed) >>=20 >> Does it make sense to do a direct commit to stable/11 >> marking the line that does this flip with a >> "Do not change this in the stable/11 branch" >> so that someone does not try to manually merge >> the change if they happen to notice the code >> is different? >=20 > I'll chew on it for a little bit. It's fairly clear what the > ramifications of swapping those lines around are, even from diff > review, and I'd like to assume no one would willfully do it if they > put a couple seconds thought into what they were about to commit. Kyle, I think what you did makes sense. I=E2=80=99ve done this and I=E2=80=99v= e seen others do similar in the past.=20 As someone who=E2=80=99s merged code in from others, I appreciate measur= es like this, which would prevent me from breaking a stable branch by accide= nt. Thanks! -Enji=