From owner-cvs-all@FreeBSD.ORG  Wed Jan 28 10:22:20 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E934116A4CE; Wed, 28 Jan 2004 10:22:20 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2136C43D2D; Wed, 28 Jan 2004 10:22:20 -0800 (PST)
	(envelope-from cracauer@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i0SIMJ0B029890;
	Wed, 28 Jan 2004 10:22:19 -0800 (PST)
	(envelope-from cracauer@repoman.freebsd.org)
Received: (from cracauer@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i0SIMJlS029889;
	Wed, 28 Jan 2004 10:22:19 -0800 (PST)
	(envelope-from cracauer)
Message-Id: <200401281822.i0SIMJlS029889@repoman.freebsd.org>
From: Martin Cracauer <cracauer@FreeBSD.org>
Date: Wed, 28 Jan 2004 10:22:19 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/bin/sh eval.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2004 18:22:21 -0000

cracauer    2004/01/28 10:22:19 PST

  FreeBSD src repository

  Modified files:
    bin/sh               eval.c 
  Log:
  The PR diff I committed recently had one bug noticed by
  Joe Marcus Clarke <marcus@FreeBSD.ORG>, subshells could lose a
  non-zero exit status.
  
  This commit is Joe's proposed patch.  Thanks!
  
  I verified that the problem Joe found is fixed and I ran a full world
  with this patch.
  
  I don't plan to ever commit language patches to /bin/sh again.  It is
  a minefield too big to navigate without a full-time committment, which
  I am not willing to do on our /bin/sh.
  
  Under normal circumstances I would recommend using NetBSD's sh which
  has a lot of language fixes (like the ones what these patches were
  about) but unfortunately they had implemented broken signal behaviour
  for shellscript containing interactive programs.  Similar issues apply
  to pdksh which is OpenBSD's sh.
  
  From my perspective bash2 is the only really working bourne sh out
  there and that one is GPLed.  Oh well.
  
  Revision  Changes    Path
  1.41      +2 -1      src/bin/sh/eval.c