Date: Fri, 20 Apr 2012 02:38:41 +0000 (UTC) From: Grzegorz Bernacki <gber@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r234477 - in projects/nand: lib/libnandfs sys/dev/nand sys/fs/nandfs Message-ID: <201204200238.q3K2cf1l018389@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: gber Date: Fri Apr 20 02:38:41 2012 New Revision: 234477 URL: http://svn.freebsd.org/changeset/base/234477 Log: nandfs: Fix build with clang - fix error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] Obtained from: Semihalf Supported by: FreeBSD Foundation, Juniper Networks Modified: projects/nand/lib/libnandfs/nandfs.c projects/nand/sys/dev/nand/nandsim_log.c projects/nand/sys/fs/nandfs/nandfs_subr.c Modified: projects/nand/lib/libnandfs/nandfs.c ============================================================================== --- projects/nand/lib/libnandfs/nandfs.c Fri Apr 20 00:45:23 2012 (r234476) +++ projects/nand/lib/libnandfs/nandfs.c Fri Apr 20 02:38:41 2012 (r234477) @@ -146,7 +146,7 @@ nandfs_open(struct nandfs *fs) memcpy(&fs->n_fsdata, &fsinfo.fs_fsdata, sizeof(fs->n_fsdata)); memcpy(&fs->n_sb, &fsinfo.fs_super, sizeof(fs->n_sb)); - snprintf(fs->n_dev, sizeof(fs->n_dev), fsinfo.fs_dev); + snprintf(fs->n_dev, sizeof(fs->n_dev), "%s", fsinfo.fs_dev); return (0); } Modified: projects/nand/sys/dev/nand/nandsim_log.c ============================================================================== --- projects/nand/sys/dev/nand/nandsim_log.c Fri Apr 20 00:45:23 2012 (r234476) +++ projects/nand/sys/dev/nand/nandsim_log.c Fri Apr 20 02:38:41 2012 (r234477) @@ -111,7 +111,7 @@ nandsim_log(struct nandsim_chip *chip, i switch(nandsim_log_output) { case NANDSIM_OUTPUT_CONSOLE: - printf(hdr); + printf("%s", hdr); va_start(ap, fmt); vprintf(fmt, ap); va_end(ap); Modified: projects/nand/sys/fs/nandfs/nandfs_subr.c ============================================================================== --- projects/nand/sys/fs/nandfs/nandfs_subr.c Fri Apr 20 00:45:23 2012 (r234476) +++ projects/nand/sys/fs/nandfs/nandfs_subr.c Fri Apr 20 02:38:41 2012 (r234477) @@ -944,7 +944,7 @@ nandfs_get_fsinfo(struct nandfsmount *nm memcpy(&fsinfo->fs_fsdata, &fsdev->nd_fsdata, sizeof(fsdev->nd_fsdata)); memcpy(&fsinfo->fs_super, &fsdev->nd_super, sizeof(fsdev->nd_super)); snprintf(fsinfo->fs_dev, sizeof(fsinfo->fs_dev), - nmp->nm_vfs_mountp->mnt_stat.f_mntfromname); + "%s", nmp->nm_vfs_mountp->mnt_stat.f_mntfromname); return (0); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204200238.q3K2cf1l018389>