From owner-svn-src-head@freebsd.org Tue Jun 4 18:48:54 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA01A15BA836; Tue, 4 Jun 2019 18:48:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it1-f174.google.com (mail-it1-f174.google.com [209.85.166.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 321F1808CB; Tue, 4 Jun 2019 18:48:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it1-f174.google.com with SMTP id h9so1871176itk.3; Tue, 04 Jun 2019 11:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2x+Q+rzD7de6rexg5PwYK1ZTvvEG+Sj3jJotQI1bqBU=; b=M/4SGmmz2M438U+eRvK0CsSV8t2331L8C4lZepqUghF/5X3ZUjx8Nq0ajAZr2GHh36 xYSGoJ1lXbonZK7Dp+aMOcA6lxaRGECieb8Go9tru7MhLSwVFR7yq6O6Mf0lkEOyA67O 6L2cEbltHZR6joZmDA9oBbLxgeF63jgUy+lMR/QSrzlDNSBaU1z6jiNA2vq3yqwV7ftQ jArjm9MhvSvUdUZE/KQ6NNA5emnNla2eaSqCEqOuXBDcWlN+gNwTSzUmOHA2FW7UXq9+ IzS2wRH6iOp1Iex1n+3/EOrilvorp/FRn0lwFHwMP/hdjUuZa2j/BvtLvrASUj9CBLuE nr+w== X-Gm-Message-State: APjAAAVri0LEfbCe5LPSyEvl53lAx+FeMWbzZCAx0g1ww92zI3wimNcZ ObZ1/95dg61pvnIz3BHWoS0BlEum13lv9Tu6Q5KPGU77 X-Google-Smtp-Source: APXvYqzINyVuX+stlLpVEqooHfOSE5QqS0gSkhGylbXJeRE5w9EiVyuCpOH3b4hA1gJ+i8/VpBIWk9w2I2x8WXsEYlQ= X-Received: by 2002:a05:660c:383:: with SMTP id x3mr5954714itj.44.1559674133007; Tue, 04 Jun 2019 11:48:53 -0700 (PDT) MIME-Version: 1.0 References: <201906041307.x54D7Acf058688@repo.freebsd.org> <13469B81-40A3-4F57-A8D3-FF8172385B5F@gmail.com> In-Reply-To: <13469B81-40A3-4F57-A8D3-FF8172385B5F@gmail.com> From: Ed Maste Date: Tue, 4 Jun 2019 14:48:35 -0400 Message-ID: Subject: Re: svn commit: r348611 - in head/sys: conf kern To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 321F1808CB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.947,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 18:48:54 -0000 On Tue, 4 Jun 2019 at 13:44, Enji Cooper wrote: > > This is awesome! One minor critique is that I would have mentioned that t= he sysctl is `kern.build_id`. You mean including the sysctl name in the commit message? > How is this linked into uname(1) though? I don=E2=80=99t see any addition= al options added to the utility in this commit. It's a mistake in the commit message, and it's not yet hooked up - see https://reviews.freebsd.org/D20511. I split it out for a separate commit and forgot to update the submitted commit message.