From owner-svn-src-head@freebsd.org Wed Oct 4 15:31:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E7FBE3C27F; Wed, 4 Oct 2017 15:31:40 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BBC06684D; Wed, 4 Oct 2017 15:31:38 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 87348681; Wed, 4 Oct 2017 17:31:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=kPWKO/uhIsUZjt1tqu7gG9rApZA=; b=nT3vexrsiH5Xlz2G2stVcNBM3bM2 a5b5yIHb9e/gk1l6dDur1dnTjBrZB4QjQkX0S/jPK6jChMKFkJxuDyzXxe3T0RXu VKvpsHHg2v8QOedghGvtgjibmS43YvGtIh9/V8mQERQw6Cz+6q6tGWfbBrTswvwF Z/OCArv9bHLILlE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=to8/1TLaUVSS5F0mSKp7DyfDahWBJSAn8Zf8mkG8zBDMe+l/34i0gTOu 2dhd1KebHUeR8Y8qLd0+yds7lMRU4WOWIoR/szeYmjpQ2yZnda4VbvpF7Xrn3EQK rpSKcCEkV1Ntc3aXw5uyZrgMr0CVMyLdM4MhZ/FVdEFhe7jzLQQ= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id da385128 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 4 Oct 2017 17:31:28 +0200 (CEST) Date: Wed, 4 Oct 2017 17:31:27 +0200 From: Emmanuel Vadot To: Ngie Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324257 - head/usr.sbin/mountd Message-Id: <20171004173127.a0748a48e208b1dd0712d755@bidouilliste.com> In-Reply-To: References: <201710040843.v948huhc028834@repo.freebsd.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 15:31:40 -0000 On Wed, 4 Oct 2017 08:07:29 -0700 Ngie Cooper wrote: >=20 > > On Oct 4, 2017, at 01:43, Emmanuel Vadot wrote: > >=20 > > Author: manu > > Date: Wed Oct 4 08:43:56 2017 > > New Revision: 324257 > > URL: https://svnweb.freebsd.org/changeset/base/324257 > >=20 > > Log: > > mountd: Convert exportlist to SLIST > >=20 > > Use SLIST from sys/queue.h instead of homebrew linked list for the exp= ortlist. > >=20 > > Reviewed by: bapt, rmacklem > > MFC after: 1 week > > Sponsored by: Gandi.net > > Differential Revision: https://reviews.freebsd.org/D12502 > >=20 > > Modified: > > head/usr.sbin/mountd/mountd.c >=20 > ... >=20 > > - ep2 =3D exphead; > > - epp =3D &exphead; > > + SLIST_INSERT_HEAD(&exphead, ep, entries); > >=20 > > - /* > > - * Insert in the list in alphabetical order. > > - */ > > - while (ep2 && strcmp(ep2->ex_fsdir, ep->ex_fsdir) < 0) { > > - epp =3D &ep2->ex_next; > > - ep2 =3D ep2->ex_next; > > - } > > - if (ep2) > > - ep->ex_next =3D ep2; > > - *epp =3D ep; > > ep->ex_flag |=3D EX_LINKED; >=20 > The new code isn?t functionally equivalent to the old code: the mount= list is no longer sorted on insert. Is that intentional? > Thanks, > -Ngie Yes, this give no value to do it. Rick noted that showmount might loose alphabetical order but even before showmount doesn't get the list alphabetically sorted. Cheers, --=20 Emmanuel Vadot