From owner-cvs-all@FreeBSD.ORG  Sun Jul  3 00:44:23 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id DB165106564A;
	Sun,  3 Jul 2011 00:44:23 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 08AFB15625B;
	Sun,  3 Jul 2011 00:44:01 +0000 (UTC)
Message-ID: <4E0FBB51.4070404@FreeBSD.org>
Date: Sat, 02 Jul 2011 17:44:01 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.18) Gecko/20110624 Thunderbird/3.1.11
MIME-Version: 1.0
To: Steve Wills <swills@FreeBSD.org>
References: <201107012233.p61MX9KQ045711@repoman.freebsd.org>
In-Reply-To: <201107012233.p61MX9KQ045711@repoman.freebsd.org>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mnag@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/databases/memcached Makefile
 ports/databases/memcached/files memcached.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2011 00:44:24 -0000

Steve asked me to review this but I haven't had (and am unlikely to 
have) time to do a detailed review. So unfortunately this is after the 
fact, my apologies.

The rc.d script should probably have KEYWORD: shutdown. The case 
statement for _enable is probably sub-optimal, it doesn't seem to 
support all of the things that checkyesno() does. Finally the 'unset 
memcached_user' is almost certainly not necessary.


hth,

Doug


On 07/01/2011 15:33, Steve Wills wrote:
> swills      2011-07-01 22:33:09 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      databases/memcached  Makefile
>      databases/memcached/files memcached.in
>    Log:
>    - add profiles support to init script
>
>    PR:             ports/155533  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155533
>    Submitted by:   swills
>    Approved by:    maintainer timeout (mnag)
>
>    Revision  Changes    Path
>    1.48      +4 -2      ports/databases/memcached/Makefile
>    1.5       +52 -2     ports/databases/memcached/files/memcached.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/memcached/Makefile.diff?&r1=1.47&r2=1.48&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/memcached/files/memcached.in.diff?&r1=1.4&r2=1.5&f=h
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/