From owner-cvs-all Mon Sep 2 13:35:21 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF21D37B400; Mon, 2 Sep 2002 13:35:14 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id B384E43E42; Mon, 2 Sep 2002 13:35:13 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g82KZCHu010567; Mon, 2 Sep 2002 14:35:12 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 02 Sep 2002 14:34:52 -0600 (MDT) Message-Id: <20020902.143452.50744905.imp@bsdimp.com> To: peter@wemm.org Cc: bde@zeta.org.au, obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile src/usr.bin/make Makefile From: "M. Warner Losh" In-Reply-To: <20020902185112.1016F2A896@canning.wemm.org> References: <20020903011057.W3883-100000@gamplex.bde.org> <20020902185112.1016F2A896@canning.wemm.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020902185112.1016F2A896@canning.wemm.org> Peter Wemm writes: : Bruce Evans wrote: : > On Mon, 2 Sep 2002, Peter Wemm wrote: : > : > > "David O'Brien" wrote: : > > > On Sat, Aug 31, 2002 at 12:18:40AM -0700, Peter Wemm wrote: : > > > [about -DBOOTSTRAPPING and newer warts] : > : > > > I thought we were going to impliment these warts with some form of : > > > __FreeBSD_version test -- so they don't impact source bases that don't : > > > need them, and more importantly so it is documented the time range they : > > > cover so we know when to remove them. : > > : > > Go for your life. Personally, I think that this sort of stuff should be : > > removed from critical bootstrap tools with extreme prejudice. : > : > I hope you mean including the __FreeBSD_version wart. : : Actually, the __FreeBSD_version tests might be pretty complicated now. : Especially since it comes from different headers. on older : systems, on newer ones. I'd rather we just reset make back : to use __RCSID (since that is in all BSD sys/cdefs.h) or plain static const : char rcsid[] = "string"; since that works on everything. But *definately* : not __FBSDID here, the #if's and crud needed to make this work would be worse : than any percieved cosmetic gain from using __FBSDID(). So what's the proceedure for making this so. Given that you and I and maybe bde agree that we should revert back to __RCSID, why not just do it and declare it verboten to change it back until 6.0 or so. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message