From owner-cvs-all  Wed May 16 20: 9:26 2001
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [209.152.133.57])
	by hub.freebsd.org (Postfix) with ESMTP
	id D4BAA37B422; Wed, 16 May 2001 20:09:21 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f4H39Le15279;
	Wed, 16 May 2001 20:09:21 -0700 (PDT)
	(envelope-from obrien)
Date: Wed, 16 May 2001 20:09:21 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: Nick Sayer <nsayer@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/crypto/telnet/libtelnet pk.c
Message-ID: <20010516200921.A15261@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200105161832.f4GIWkq20440@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200105161832.f4GIWkq20440@freefall.freebsd.org>; from nsayer@FreeBSD.org on Wed, May 16, 2001 at 11:32:46AM -0700
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, May 16, 2001 at 11:32:46AM -0700, Nick Sayer wrote:
> nsayer      2001/05/16 11:32:46 PDT
> 
>   Modified files:
>     crypto/telnet/libtelnet pk.c 
>   Log:
>   srandomdev() affords us the opportunity to radically improve, and at the
>   same time simplify, the random number selection code.

There is _ZERO_ way you even tried to compile this C code (C rules are
different from C++...):


Index: pk.c
===================================================================
RCS file: /home/ncvs/src/crypto/telnet/libtelnet/pk.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -u -1 -r1.3 -r1.4
--- pk.c	2000/07/16 05:52:42	1.3
+++ pk.c	2001/05/16 18:32:46	1.4
@@ -1,3 +1,3 @@
 /* public key routines */
-/* $FreeBSD: src/crypto/telnet/libtelnet/pk.c,v 1.3 2000/07/16 05:52:42 peter Exp $ */
+/* $FreeBSD: src/crypto/telnet/libtelnet/pk.c,v 1.4 2001/05/16 18:32:46 nsayer Exp $ */
 /* functions:
@@ -119,2 +119,3 @@
 {
+#if 0
         int i,f;
@@ -142,2 +143,8 @@
         }
+#else
+	srandomdev();
+	for (i = 0; i < seedsize; i++) {
+		seed[i] = random() & 0xff;
+	}
+#endif
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message