From owner-p4-projects@FreeBSD.ORG  Wed Sep 10 20:22:09 2014
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 70FB05B5; Wed, 10 Sep 2014 20:22:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 32E735B3
 for <perforce@freebsd.org>; Wed, 10 Sep 2014 20:22:09 +0000 (UTC)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
 [IPv6:2001:1900:2254:2068::682:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1F1208A8
 for <perforce@freebsd.org>; Wed, 10 Sep 2014 20:22:09 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.9/8.14.9) with ESMTP id s8AKM8kO001137
 for <perforce@freebsd.org>; Wed, 10 Sep 2014 20:22:08 GMT
 (envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.9/8.14.9/Submit) id s8AKM8fN001134
 for perforce@freebsd.org; Wed, 10 Sep 2014 20:22:08 GMT
 (envelope-from jhb@freebsd.org)
Date: Wed, 10 Sep 2014 20:22:08 GMT
Message-Id: <201409102022.s8AKM8fN001134@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
Subject: PERFORCE change 1200099 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects/>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Sep 2014 20:22:09 -0000

http://p4web.freebsd.org/@@1200099?ac=10

Change 1200099 by jhb@jhb_ralph on 2014/09/10 20:21:43

	Move this earlier and compare against uap->prot to avoid
	implicit truncation.

Affected files ...

.. //depot/projects/smpng/sys/vm/vm_mmap.c#107 edit

Differences ...

==== //depot/projects/smpng/sys/vm/vm_mmap.c#107 (text+ko) ====

@@ -211,6 +211,9 @@
 	struct vmspace *vms = td->td_proc->p_vmspace;
 	cap_rights_t rights;
 
+	if ((uap->prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_NONE)) != 0)
+		return (EINVAL);
+
 	addr = (vm_offset_t) uap->addr;
 	size = uap->len;
 	prot = uap->prot;
@@ -246,8 +249,6 @@
 	}
 	if ((flags & (MAP_EXCL | MAP_FIXED)) == MAP_EXCL)
 		return (EINVAL);
-	if ((prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_NONE)) != 0)
-		return (EINVAL);
 	if ((flags & (MAP_ANON | MAP_SHARED | MAP_PRIVATE)) == 0 ||
 	    (flags & (MAP_SHARED | MAP_PRIVATE)) == (MAP_SHARED | MAP_PRIVATE))
 		return (EINVAL);