Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Mar 2008 17:15:21 +0100 (CET)
From:      Harti Brandt <hartmut.brandt@dlr.de>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/make arch.c
Message-ID:  <20080304171410.V893@knop-beagle.kn.op.dlr.de>
In-Reply-To: <200803041556.m24FuIqw012139@repoman.freebsd.org>
References:  <200803041556.m24FuIqw012139@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Mar 2008, Warner Losh wrote:

WL>imp         2008-03-04 15:56:18 UTC
WL>
WL>  FreeBSD src repository
WL>
WL>  Modified files:
WL>    usr.bin/make         arch.c 
WL>  Log:
WL>  <limits.h> is necessary for using INT_MIN, so included it here
WL>  explicitly rather than relying on name space pollution to pull it in
WL>  for us.
WL>  
WL>  NB: The usage of INT_MIN is somewhat bogus and suspect to my eye, but this
WL>  commit doesn't address that issue.

Yes. This looks like a bug. ArchStatMember returns INT64_MIN if it cannot 
stat the archive member. So the caller must check for INT64_MIN.

harti



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080304171410.V893>