From owner-freebsd-bugs Tue Sep 29 23:10:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA00470 for freebsd-bugs-outgoing; Tue, 29 Sep 1998 23:10:09 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA00461 for ; Tue, 29 Sep 1998 23:10:05 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id XAA10650; Tue, 29 Sep 1998 23:10:00 -0700 (PDT) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA29834 for ; Tue, 29 Sep 1998 23:04:24 -0700 (PDT) (envelope-from andre.albsmeier@mchp.siemens.de) Received: from mail.siemens.de (salomon.siemens.de [139.23.33.13]) by david.siemens.de (8.9.1a/8.9.1) with ESMTP id IAA29485 for ; Wed, 30 Sep 1998 08:04:11 +0200 (MET DST) Received: from curry.mchp.siemens.de (daemon@curry.mchp.siemens.de [146.180.31.23]) by mail.siemens.de (8.9.1a/8.9.1) with ESMTP id IAA26473 for ; Wed, 30 Sep 1998 08:04:01 +0200 (MET DST) Received: (from daemon@localhost) by curry.mchp.siemens.de (8.8.8/8.8.8) id IAA24205 for ; Wed, 30 Sep 1998 08:04:03 +0200 (CEST) Message-Id: <199809300604.IAA25368@internal> Date: Wed, 30 Sep 1998 08:04:03 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: kern/8097: mountpoint on NFS server can be removed by NFS client (patch for -STABLE) Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 8097 >Category: kern >Synopsis: mountpoint on NFS server can be removed by NFS client (patch for -STABLE) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 29 23:10:00 PDT 1998 >Last-Modified: >Originator: Andre Albsmeier >Organization: >Release: FreeBSD 2.2.7-STABLE i386 >Environment: -stable only, -current is fixed already. >Description: see kern/7272 >How-To-Repeat: see kern/7272 >Fix: Kirk McKusick fixed this for -current (thanks again) and here is his patch brought to -stable by me. I have tested it and it works: *** sys/ufs/ufs/ufs_vnops.c.ORI Wed Sep 30 07:37:48 1998 --- sys/ufs/ufs/ufs_vnops.c Wed Sep 30 07:47:32 1998 *************** *** 1438,1443 **** --- 1438,1447 ---- * ".." will contain a reference to * the current directory and thus be * non-empty.) + * Do not allow the removal of mounted on + * directories (this can happen when an NFS + * exported filesystem tries to remove a + * locally mounted on directory). */ error = 0; if (ip->i_nlink != 2 || *************** *** 1453,1458 **** --- 1457,1466 ---- if ((dp->i_flags & APPEND) || (ip->i_flags & (NOUNLINK | IMMUTABLE | APPEND))) { error = EPERM; + goto out; + } + if (vp->v_mountedhere != 0) { + error = EINVAL; goto out; } /* >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message