From owner-freebsd-ports@FreeBSD.ORG Tue Mar 12 17:44:52 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8FB71303; Tue, 12 Mar 2013 17:44:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id E0E9173B; Tue, 12 Mar 2013 17:44:51 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r2CHiRLQ016512; Tue, 12 Mar 2013 19:44:27 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.0 kib.kiev.ua r2CHiRLQ016512 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r2CHiRuM016511; Tue, 12 Mar 2013 19:44:27 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 12 Mar 2013 19:44:27 +0200 From: Konstantin Belousov To: Bernhard Fr?hlich Subject: Re: VirtualBox patch Message-ID: <20130312174427.GO3794@kib.kiev.ua> References: <513DA3AD.1000603@gmail.com> <1363089703.20974.6.camel@z6000.lenzicasa> <20130312151751.GJ3794@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HYp1lSkoFcXgiw1x" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: Ferenc Balku , Sergio de Almeida Lenzi , ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 17:44:52 -0000 --HYp1lSkoFcXgiw1x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 12, 2013 at 04:58:34PM +0100, Bernhard Fr?hlich wrote: > On Tue, Mar 12, 2013 at 4:17 PM, Konstantin Belousov > wrote: > > On Tue, Mar 12, 2013 at 09:01:43AM -0300, Sergio de Almeida Lenzi wrote: > >> Em Seg, 2013-03-11 ??s 10:28 +0100, Ferenc Balku escreveu: > >> > >> > Hi Sergio! > >> > > >> > Awfully sorry to disturb You, but I have found this link via Google > >> > http://lists.freebsd.org/pipermail/freebsd-ports/2013-March/081979.h= tml > >> > and can not find the patch to download a make VBox work again on our > >> > FBSD10 test server. > >> > > >> > Can You please send me a link to download the patch. > >> > > >> > Thanks in advance, > >> > > >> > Best Regards > >> > > >> > Ferenc Balku > >> > >> > >> No problem I was "travel business... > >> here is the patch, > >> the list does not allow attach files... > >> > >> go to the /usr/ports/emulators/virtualbox-ose-kmod, > >> put the fix in the "files" directory with a name like =3D=3D> > >> patch-the-freebsd-kernel > >> and do a make clean install > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h.orig > >> 2012-12-19 16:27:29.000000000 -0200 > >> +++ src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h 2013-03-09 > >> 14:42:18.924039639 -0300 > >> @@ -50,6 +50,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -70,6 +71,12 @@ > >> #include > >> #include > >> > >> +/* > >> + fix VM_OBJ_LOCK > >> +*/ > >> +#define VM_OBJECT_LOCK(o) VM_OBJECT_RLOCK(o) > >> +#define VM_OBJECT_UNLOCK(o) VM_OBJECT_RUNLOCK(o) > > > > This is definitely wrong. For the blind substitution, you should > > use VM_OBJECT_WLOCK/VM_OBJECT_WUNLOCK. >=20 > It would be great if someone could come up with a proper patch. > All I've seen so far looks wrong or hackish and I cannot add that > to the port nor send it upstream to get it fixed for future releases. The patch would be to replace all occurences of VM_OBJECT_LOCK with VM_OBJECT_WLOCK, and VM_OBJECT_UNLOCK with VM_OBJECT_WUNLOCK. I assume that vbox module does not assert the lock state. Sorry, I am not set up to produce the patch, but it should just a mechanical substitution. --HYp1lSkoFcXgiw1x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRP2l6AAoJEJDCuSvBvK1BdAYP/3joIFYkM1leNLO7oEHNbOXi XbQGded7HdCXZNYBf+JTBRebuSIdpnc+8DLrcvCuPMM9OM5N2TDr5xT3UhxB3RMG Ny7lwbGsmF8d2X9PYFfV+M4qjf6h/+JLgcvQTUXpStFHa158xHlZKcAxgZcRU1e1 Jo/0vxg/tvcQU+mV5448c+LjUcYOpOpZdjBggxAxpGRngrPNPkv0CtLXlLtbMsp2 DNr+B/dmFT2KErdv7llkv5ib4TlwVVaqdBv+RIJ8ZSPkTLFwzopJt+IalJXXxnVF nVkNNDkD3DNxM8rdxG3+i2oMgmSDMDGyMG0rx4vTTMwTQ+L2EJOJ9QECifJv6h6T hjtI2Bi0ntgtWqElB/WnL0YOgvcLKdE3CrhhGR9qHBoE3nvJfDpvL3MXm7KT6Cyt H3oTF6Xe/TISvlD4pdfM9fhm36ezTyX7BLh+Wlv3q0vXUJYf75qZzdLKvED/c14B U3k/7/FCYJ/PpIowRq8dcQws0oZPUSHzwpBDhqpYgxrnsDDLQhgQxXNUCrhbD+lA IqJUfKewF2orB11qe6+KjNF4H5T7yxq/M2pENINk24D4z9X4XjCdOZ6fzTT2pXnn Z5AT9Mflr6soPhsGTH88QyNu65ilgQUSqYg0hieHpR26bb5gPiXZhIun/6itUiPH yGZ8VlbTWXA2reZBzFbd =UcYi -----END PGP SIGNATURE----- --HYp1lSkoFcXgiw1x--