Date: Mon, 14 Apr 2014 10:29:56 +0200 From: Kurt Jaeger <lists@opsec.eu> To: Benjamin Podszun <dar@darklajid.de> Cc: crees@freebsd.org, freebsd-ports@freebsd.org Subject: Re: FreeBSD Port: security/sshguard-pf Message-ID: <20140414082956.GB2341@home.opsec.eu> In-Reply-To: <fe85c5ec-65aa-425d-9e58-f70f277ad491@darklajid.de> References: <53453547.2070307@uni-bielefeld.de> <fe85c5ec-65aa-425d-9e58-f70f277ad491@darklajid.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi!
> Looking at the rc script and the diff [1] the problem's easy enough:
> ${sshguard_pidfile} is passed as parameter to -i, but isn't set in the
> script/has no default value. Either the related line from the previous
> revision should be revived or the substitution should change to use
> ${pidfile}, which _is_ set.
>
> What now? To PR or not?
PR is always a good idea. If combined with a patch that fixes the
problem, more so.
--
pi@opsec.eu +49 171 3101372 6 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140414082956.GB2341>