Date: Wed, 13 May 2009 09:12:27 +0400 From: Boris Samorodov <bsam@ipt.ru> To: Ion-Mihai Tetcu <itetcu@FreeBSD.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/linux-f8-openmotif Makefile pkg-plist Message-ID: <56850116@bb.ipt.ru> In-Reply-To: <20090513003531.29453ee6@it.buh.tecnik93.com> (Ion-Mihai Tetcu's message of "Wed\, 13 May 2009 00\:35\:31 %2B0300") References: <200905121614.n4CGEiv0012670@repoman.freebsd.org> <4A09AA55.8080108@p6m7g8.com> <03260409@bb.ipt.ru> <20090513003531.29453ee6@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 13 May 2009 00:35:31 +0300 Ion-Mihai Tetcu wrote:
> On Tue, 12 May 2009 21:28:06 +0400
> Boris Samorodov <bsam@ipt.ru> wrote:
> > On Tue, 12 May 2009 12:56:53 -0400 Philip M. Gollucci wrote:
> > > Boris Samorodov wrote:
> >
> > > > No PORTREVISION bump is needed.
> > > > | -BUILD_DEPENDS= rpm2cpio:${PORTSDIR}/archivers/rpm
> > > I thought you always had to BUMP PORTREVISION when changing DEPENDS
> > > since you directly affect the resultant package ? Can you enlighten
> > > me ?
> >
> > Two arguments:
> > . the package for this port is never built;
> In general, this argument is is wrong, as one can use FORCE_PACKAGES to
> build them locally.
I was talking about oficial packages. As for custom packages I'm
not sure if we should bump PORTREVISION when any custom package
may be affected by a commit. Should a PORTREVISION be bumped if
non-defaults (say, OPTIONS) are changed?
> > . this dependency still (indirectly) exists since this port
> > depends upon linux_base-f8 which depends upon archivers/rpm.
> So the make describe output is the same?
Strictly speaking, no: archivers/rpm moved from build_depends
to extract_depends. But that doesn't affect a package using.
Those two arguments in conjunction convinced me not to bump
PORTREVISION.
WBR
--
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56850116>