From owner-freebsd-threads@FreeBSD.ORG  Tue Jun  8 01:07:59 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 321B616A4E8; Tue,  8 Jun 2004 01:07:59 +0000 (GMT)
Received: from exchhz01.viatech.com.cn (ip-40-162-97-218.anlai.com
	[218.97.162.40])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1B63D43D49; Tue,  8 Jun 2004 01:07:55 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from freebsd.org (DAVIDWNT [10.4.1.99]) by exchhz01.viatech.com.cn
	with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21)
	id M22V47LA; Tue, 8 Jun 2004 09:07:51 +0800
Message-ID: <40C51203.8050508@freebsd.org>
Date: Tue, 08 Jun 2004 09:10:27 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.5b) Gecko/20030723 Thunderbird/0.1
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Tim Robbins <tjr@freebsd.org>
References: <20040607215054.GA41798@cat.robbins.dropbear.id.au>
In-Reply-To: <20040607215054.GA41798@cat.robbins.dropbear.id.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-amd64@freebsd.org
cc: freebsd-threads@freebsd.org
Subject: Re: [tjr@FreeBSD.org: cvs commit:src/lib/libpthread/arch/amd64/amd64
 context.S]
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2004 01:07:59 -0000

Is there any reason to use memory indirect jump ? did you
have benchmarked context switch speed before and after this commit ?
I won't use such indirect jump in speed sensitive case, it is
not CPU branch trace cache friendly, it is better to use
ret to match call in up level.

David Xu

Tim Robbins wrote:
> Anyone who has resorted to using libc_r instead of libpthread on amd64
> should update their sources (ensuring they get context.S revision 1.6),
> rebuild and reinstall libpthread (or world), then give it another try.
> The bug I just fixed looks to have been responsible for the mysterious
> crashes I was seeing in Mozilla/Firefox, XMMS and GNOME.
> 
> 
> Tim
> 
> ----- Forwarded message from "Tim J. Robbins" <tjr@FreeBSD.org> -----
> 
> From: "Tim J. Robbins" <tjr@FreeBSD.org>
> Date: Mon, 7 Jun 2004 21:25:17 +0000 (UTC)
> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
> 	cvs-all@FreeBSD.org
> Subject: cvs commit: src/lib/libpthread/arch/amd64/amd64 context.S
> X-FreeBSD-CVS-Branch: HEAD
> Precedence: bulk
> X-Loop: FreeBSD.ORG
> X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.15.7
> 
> tjr         2004-06-07 21:25:16 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libpthread/arch/amd64/amd64 context.S 
>   Log:
>   Avoid clobbering the red zone when running on the new context's stack in
>   _amd64_restore_context().
>   
>   Revision  Changes    Path
>   1.6       +5 -0      src/lib/libpthread/arch/amd64/amd64/context.S
> 
> ----- End forwarded message -----
> _______________________________________________
> freebsd-threads@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-threads
> To unsubscribe, send any mail to "freebsd-threads-unsubscribe@freebsd.org"
>