Date: Sun, 29 Nov 2009 11:50:02 GMT From: olli hauer <ohauer@gmx.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/140978: [patch] port lang/tclX fix build Message-ID: <200911291150.nATBo2jD001743@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/140978; it has been noted by GNATS. From: olli hauer <ohauer@gmx.de> To: <bug-followup@FreeBSD.org>, Mikhail T. <mi+thun@aldan.algebra.com> Cc: olli hauer <ohauer@gmx.de> Subject: Re: ports/140978: [patch] port lang/tclX fix build Date: Sun, 29 Nov 2009 12:46:45 +0100 (CET) Mikhail T. wrote: ... > How about the attached patch? It is looking for each man-page under both > names: page and pageVERSION... > > I also incorporated your point regarding resources (not present under > 8.5 and above) and a similar point regarding lset. Hi Mikhail, thanks for the patch, it seems tinderbox builds are working now. I found one interesting difference in the build logs, but I'm not sure if this is important, see attached diff from build logs. If this doesn't break anything, please commit your patch. Send me a note If you need the full build logs, or if I should do some more build tests. -- cheers, olli --- build_log_diff begins here --- ... configure: creating ./config.status config.status: creating Makefile /usr/bin/sed -i.bak -e 's,^TCLSH_PROG.*,TCLSH_PROG=/usr/local/bin/tclsh8.5,' -e 's,TCL_LIBRARY=.*,\\,' /work/a/ports/lang/tclX/work/tclx8.4/Makefile # Disabling the failing help.test /bin/mv /work/a/ports/lang/tclX/work/tclx8.4/tests/help.test /work/a/ports/lang/tclX/work/tclx8.4/tests/help.test.dis ===> Building for tclX-8.4_3 (echo 'package ifneeded Tclx 8.4 [list load [file join $dir libtclx8.4.so] Tclx]' ) > pkgIndex.tcl ... build without patch or with my patch: cc -pipe ... -fPIC -c `echo ./generic/tclXoscmds.c` -o tclXoscmds.o cc -pipe ... -fPIC -c `echo ./generic/tclXlgets.c` -o tclXlgets.o build with your new patch: cc -pipe ... -fPIC -c `echo ./generic/tclXoscmds.c` -o tclXoscmds.o --- build_log_diff ends here ---
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911291150.nATBo2jD001743>