From owner-freebsd-mips@FreeBSD.ORG Mon May 17 14:44:19 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E580106564A for ; Mon, 17 May 2010 14:44:19 +0000 (UTC) (envelope-from aduane@juniper.net) Received: from exprod7og102.obsmtp.com (exprod7og102.obsmtp.com [64.18.2.157]) by mx1.freebsd.org (Postfix) with ESMTP id 4CF578FC1A for ; Mon, 17 May 2010 14:44:18 +0000 (UTC) Received: from source ([66.129.224.36]) (using TLSv1) by exprod7ob102.postini.com ([64.18.6.12]) with SMTP ID DSNKS/FWQRr/TyS2+78SORwwpGDNFurWtfxx@postini.com; Mon, 17 May 2010 07:44:18 PDT Received: from p-emfe01-wf.jnpr.net (172.28.145.24) by P-EMHUB01-HQ.jnpr.net (172.24.192.35) with Microsoft SMTP Server (TLS) id 8.1.436.0; Mon, 17 May 2010 07:41:15 -0700 Received: from EMBX01-WF.jnpr.net ([fe80::1914:3299:33d9:e43b]) by p-emfe01-wf.jnpr.net ([fe80::d0d1:653d:5b91:a123%11]) with mapi; Mon, 17 May 2010 10:41:14 -0400 From: Andrew Duane To: "C. Jayachandran" , Neel Natu Date: Mon, 17 May 2010 10:41:13 -0400 Thread-Topic: Minor fixup for the MIPS SMP platform code. Thread-Index: Acr1zfIPksi6VXqFS4ahgbCopN4vfQAAMC0g Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-mips@freebsd.org" Subject: RE: Minor fixup for the MIPS SMP platform code. X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 14:44:19 -0000 A really minor nit: in sys/mips/rmi/xlr_machdep.c, you might as well put th= e assert for "Interrupts enabled" before setting the COP_2 and COP_0 bits i= n the stat register. There's no real difference of effect, the code just fe= els a bit cleaner to check for validity before setting anything else. /Andrew =20 =20 > -----Original Message----- > From: owner-freebsd-mips@freebsd.org=20 > [mailto:owner-freebsd-mips@freebsd.org] On Behalf Of C. Jayachandran > Sent: Monday, May 17, 2010 10:33 AM > To: Neel Natu > Cc: freebsd-mips@freebsd.org > Subject: Minor fixup for the MIPS SMP platform code. >=20 > The attached patch (also at=20 > http://sites.google.com/site/cjayachandran/files) > has two changes: > - moves the intr masking code to platform_init_ap, so that we=20 > can avoid the > #ifdef for XLR > - adds a platform_smp_topo() function so that platforms can=20 > define their > topology >=20 > I've also attempted to fixup sys/mips/sibyte to reflect these=20 > changes, but > it might need further work. > sys/mips/cavium also might need similar changes for SMP. >=20 > Please review and apply if the changes are okay. >=20 > Thanks, > JC. > =