From owner-cvs-all@FreeBSD.ORG  Tue Jul  8 08:19:17 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D3C8F37B401; Tue,  8 Jul 2003 08:19:17 -0700 (PDT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F165943FA3; Tue,  8 Jul 2003 08:19:16 -0700 (PDT)
	(envelope-from sam@errno.com)
Received: from melange.errno.com (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h68FJF7N066988
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Tue, 8 Jul 2003 08:19:16 -0700 (PDT)
	(envelope-from sam@errno.com)
Date: Tue, 08 Jul 2003 08:19:15 -0700
From: Sam Leffler <sam@errno.com>
To: Garrett Wollman <wollman@lcs.mit.edu>,
	Bill Paul <wpaul@FreeBSD.org>
Message-ID: <690828498.1057652355@melange.errno.com>
In-Reply-To: <200307080101.h6811sTT018888@khavrinen.lcs.mit.edu>
References: <200307071845.h67Ij1N1016542@khavrinen.lcs.mit.edu>
 	<20030707234511.3B0FB37B401@hub.freebsd.org>
 <200307080101.h6811sTT018888@khavrinen.lcs.mit.edu>
X-Mailer: Mulberry/3.0.3 (Win32)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2003 15:19:18 -0000

> <<On Mon, 7 Jul 2003 16:45:11 -0700 (PDT), wpaul@FreeBSD.ORG (Bill Paul)
> said:
>
>> 1) Change vlan_input() to apply EVL_VLANOFTAG() to all incoming tags
>>    (in both hardware and non-hardware tagging cases) and change the
>>    vlan_ioctl() function to only accept vlan tags from 0 to 4095
>>    and return EINVAL if the caller tries to set any of the other
>>    bits. (Prevent user from shooting self in foot.)
>
> I believe that this is the correct choice.  (It's probably a result of
> my stupidity that the vlan driver didn't do this already.)
>
> At some point we should do something sensible with the other bits,
> too.  In some applications it might be useful to allow the user to
> configure the .1p priority bits, outside of a VLAN context.  (We
> should be able to at least decode frames that arrive with .1p
> encapsulation but .1Q tag 0.)
>

I need/want these bits for the Atheros driver which has multi-q h/w support 
for QOS.  I haven't had the time to look at a general solution for dealing 
with this within the network stack.

	Sam