From owner-p4-projects@FreeBSD.ORG  Wed May  9 08:41:15 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9C9F116A409; Wed,  9 May 2007 08:41:15 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 40DE316A400;
	Wed,  9 May 2007 08:41:15 +0000 (UTC) (envelope-from fli@FreeBSD.org)
Received: from mx1.h3q.net (mx1.h3q.net [212.37.5.30])
	by mx1.freebsd.org (Postfix) with ESMTP id 0072A13C48A;
	Wed,  9 May 2007 08:41:14 +0000 (UTC) (envelope-from fli@FreeBSD.org)
Received: from [192.168.1.100] (81-232-22-115-no50.tbcn.telia.com
	[81.232.22.115])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: fli@shapeshifter.se)
	by mx1.h3q.net (Postfix) with ESMTP id 0707B78C20;
	Wed,  9 May 2007 10:08:47 +0200 (CEST)
Message-ID: <4641818B.4030507@FreeBSD.org>
Date: Wed, 09 May 2007 10:08:43 +0200
From: Fredrik Lindberg <fli@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.0 (X11/20070420)
MIME-Version: 1.0
To: Roman Divacky <rdivacky@FreeBSD.org>
References: <200705082229.l48MTrbh069129@repoman.freebsd.org>
	<20070509070626.GA41419@freebsd.org>
In-Reply-To: <20070509070626.GA41419@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 119527 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2007 08:41:15 -0000

Roman Divacky wrote:
> On Tue, May 08, 2007 at 10:29:53PM +0000, Fredrik Lindberg wrote:
>> http://perforce.freebsd.org/chv.cgi?CH=119527
>>
>> Change 119527 by fli@fli_genesis on 2007/05/08 22:29:14
>>
>> 	Add data structures needed by the stack.
>> 	A Double-linked list and a hash table.
> 
> what about sys/queue.h ? it provides various abstract data types
> including double-linked list
> 

Yes, I know it does provide that, and I've used it a lot in the past.
A while ago I needed a linked list for another project where I needed
to be independent of FreeBSD. So I rolled my own (with a similar api)
and I've used it ever since. (It can be used both as a stack and queue).

It's not exactly rocket-science and it does increase portability since
this is a userland application.
If there aren't any major objections or other selling points in favor
for sys/queue.h (in a userland application!) I'm just going to leave
it as it is.