From owner-freebsd-current  Thu Apr 27 22:42:15 2000
Delivered-To: freebsd-current@freebsd.org
Received: from ns.cvzoom.net (ns.cvzoom.net [208.226.154.2])
	by hub.freebsd.org (Postfix) with SMTP id C4B9A37B6DA
	for <current@FreeBSD.ORG>; Thu, 27 Apr 2000 22:42:10 -0700 (PDT)
	(envelope-from dmmiller@cvzoom.net)
Received: (qmail 1081 invoked from network); 28 Apr 2000 05:42:09 -0000
Received: from lc210.cvzoom.net (HELO cvzoom.net) (208.226.154.210)
  by ns.cvzoom.net with SMTP; 28 Apr 2000 05:42:09 -0000
Message-ID: <390924AD.6313EDAA@cvzoom.net>
Date: Fri, 28 Apr 2000 01:42:05 -0400
From: Donn Miller <dmmiller@cvzoom.net>
X-Mailer: Mozilla 4.72 [en] (X11; I; FreeBSD 5.0-CURRENT i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Will Andrews <andrews@technologist.com>
Cc: Poul-Henning Kamp <phk@FreeBSD.ORG>, current@FreeBSD.ORG
Subject: Re: PATCH: Removal of unneeded <sys/kernel.h>
References: <58618.956742611@critter.freebsd.dk> <20000428012630.B2098@argon.blackdawn.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Will Andrews wrote:
> 
> On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote:

> > Comments, tests and reviews please.
> 
> Just write a script to check all #include's against their prototypes and
> have it autogen diffs.

I agree.  I like the automated method better.  What happens if someone
accidentally commits an additional unnecessary #include after the
patch has been applied?

- Donn


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message