Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Aug 2016 12:08:42 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r303890 - in head/sys: contrib/ncsw/user/env contrib/octeon-sdk dev/auxio dev/bktr dev/e1000 dev/ixgb dev/ixgbe dev/ixl dev/netmap dev/pci dev/sound/sbus dev/tpm kern mips/nlm/dev/net m...
Message-ID:  <20160810114337.A1075@besplex.bde.org>
In-Reply-To: <201608091932.u79JW6Y6069448@repo.freebsd.org>
References:  <201608091932.u79JW6Y6069448@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 9 Aug 2016, [UTF-8] Jean-S=C3=A9bastien P=C3=A9dron wrote:

> Log:
>  Consistently use `device_t`
>
>  Several files use the internal name of `struct device` instead of
>  `device_t` which is part of the public API. This patch changes all
>  `struct device *` to `device_t`.

device_t is properly opque, yet it still causes namespace problems and
is harder to use, especially in userland where it doesn't exist.

Headers now have namespace pollution/dependencies on <sys/bus.h> where
they carefully used 'struct device' before.

Many kernel .c files probably depend on magic ordering to compile now.
Alphabetical ordering mostly works accidentally since b < [c-z].

Bruce
From owner-svn-src-head@freebsd.org  Wed Aug 10 03:10:36 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04AA5BB48E1;
 Wed, 10 Aug 2016 03:10:36 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AE6411813;
 Wed, 10 Aug 2016 03:10:35 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7A3AYoI038809;
 Wed, 10 Aug 2016 03:10:34 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7A3AYYf038805;
 Wed, 10 Aug 2016 03:10:34 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201608100310.u7A3AYYf038805@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Garrett Cooper <ngie@FreeBSD.org>
Date: Wed, 10 Aug 2016 03:10:34 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r303900 - in head/cddl/usr.sbin/dtrace/tests:
 common/raise common/safety tools
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>;
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Aug 2016 03:10:36 -0000

Author: ngie
Date: Wed Aug 10 03:10:34 2016
New Revision: 303900
URL: https://svnweb.freebsd.org/changeset/base/303900

Log:
  Highball memory requirement (4GB) with common/{raise,safety}
  
  Both test suites require more memory than my amd64 VM using
  GENERIC-NODEBUG can provide and reliably panic it with OOM issues in
  dtrace(4).
  
  Some of the testcases fail, but this at least bypasses the panic behavior
  on platforms that don't have enough resources
  
  MFC after: 2 weeks
  Discussed with: markj
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/cddl/usr.sbin/dtrace/tests/common/raise/Makefile
  head/cddl/usr.sbin/dtrace/tests/common/safety/Makefile
  head/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh

Modified: head/cddl/usr.sbin/dtrace/tests/common/raise/Makefile
==============================================================================
--- head/cddl/usr.sbin/dtrace/tests/common/raise/Makefile	Wed Aug 10 02:44:46 2016	(r303899)
+++ head/cddl/usr.sbin/dtrace/tests/common/raise/Makefile	Wed Aug 10 03:10:34 2016	(r303900)
@@ -20,4 +20,6 @@ CFILES= \
      tst.raise3.c  \
 
 
+TEST_METADATA.t_dtrace_contrib+=	required_memory="4g"
+
 .include "../../dtrace.test.mk"

Modified: head/cddl/usr.sbin/dtrace/tests/common/safety/Makefile
==============================================================================
--- head/cddl/usr.sbin/dtrace/tests/common/safety/Makefile	Wed Aug 10 02:44:46 2016	(r303899)
+++ head/cddl/usr.sbin/dtrace/tests/common/safety/Makefile	Wed Aug 10 03:10:34 2016	(r303900)
@@ -53,4 +53,6 @@ CFILES= \
 
 
 
+TEST_METADATA.t_dtrace_contrib+=	required_memory="4g"
+
 .include "../../dtrace.test.mk"

Modified: head/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh
==============================================================================
--- head/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed Aug 10 02:44:46 2016	(r303899)
+++ head/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed Aug 10 03:10:34 2016	(r303900)
@@ -34,15 +34,28 @@ genmakefile()
 
     # One-off variable definitions.
     local special
-    if [ "$basedir" = proc ]; then
+    case "$basedir" in
+    proc)
         special="
 LIBADD.tst.sigwait.exe+= rt
 "
-    elif [ "$basedir" = uctf ]; then
+        ;;
+    raise)
+	special="
+TEST_METADATA.t_dtrace_contrib+=	required_memory=\"4g\"
+"
+        ;;
+    safety)
+	special="
+TEST_METADATA.t_dtrace_contrib+=	required_memory=\"4g\"
+"
+        ;;
+    uctf)
         special="
 WITH_CTF=YES
 "
-    fi
+        ;;
+    esac
 
     local makefile=$(mktemp)
     cat <<__EOF__ > $makefile



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160810114337.A1075>