From owner-cvs-src@FreeBSD.ORG Wed Jul 23 17:12:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFB9A37B401 for ; Wed, 23 Jul 2003 17:12:48 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A09B943FE0 for ; Wed, 23 Jul 2003 17:12:47 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 40501 invoked by uid 1000); 24 Jul 2003 00:12:49 -0000 Date: Wed, 23 Jul 2003 17:12:49 -0700 (PDT) From: Nate Lawson To: Peter Wemm In-Reply-To: <20030724000408.E479E37B481@hub.freebsd.org> Message-ID: <20030723171139.I40342@root.org> References: <20030724000408.E479E37B481@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/tar/src tar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2003 00:12:49 -0000 On Wed, 23 Jul 2003, Peter Wemm wrote: > Fix an annoying bug in tar. When it converted 'tar zcf' to 'tar -z -c -f' > it forgot to null terminate the new argv[] array. If you mixed this > with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you > could end up with a segfault. This isn't strictly a phkmalloc victory > since tar walks off the end of an array rather than use uninitialized > malloc memory, but phkmalloc makes it easier to provoke. > > Revision Changes Path > 1.3 +4 -1 src/contrib/tar/src/tar.c It is a victory for the Peter Murphy field though since without it, we would never have triggered this bug. -Nate