From owner-freebsd-current Thu Apr 27 22:46:10 2000 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 5B59B37B5CA for ; Thu, 27 Apr 2000 22:46:08 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id HAA69169; Fri, 28 Apr 2000 07:45:37 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Donn Miller Cc: Will Andrews , current@FreeBSD.ORG Subject: Re: PATCH: Removal of unneeded In-reply-to: Your message of "Fri, 28 Apr 2000 01:42:05 EDT." <390924AD.6313EDAA@cvzoom.net> Date: Fri, 28 Apr 2000 07:45:36 +0200 Message-ID: <69167.956900736@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <390924AD.6313EDAA@cvzoom.net>, Donn Miller writes: >Will Andrews wrote: >> >> On Wed, Apr 26, 2000 at 11:50:11AM +0200, Poul-Henning Kamp wrote: > >> > Comments, tests and reviews please. >> >> Just write a script to check all #include's against their prototypes and >> have it autogen diffs. > >I agree. I like the automated method better. What happens if someone >accidentally commits an additional unnecessary #include after the >patch has been applied? I agree too, but nobody has written *that* code yet. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message