From owner-freebsd-audit Wed Dec 6 3:24: 6 2000 From owner-freebsd-audit@FreeBSD.ORG Wed Dec 6 03:24:04 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 6970637B400; Wed, 6 Dec 2000 03:24:04 -0800 (PST) Received: from earth.causticlabs.com (oca-c1s2-09.mfi.net [209.26.94.56]) by peitho.fxp.org (Postfix) with ESMTP id 3C61513613; Wed, 6 Dec 2000 06:24:07 -0500 (EST) Received: by earth.causticlabs.com (Postfix, from userid 1000) id 344211F23; Wed, 6 Dec 2000 06:24:33 -0500 (EST) Date: Wed, 6 Dec 2000 06:24:33 -0500 From: Chris Faulhaber To: Nathan Ahlstrom Cc: audit@FreeBSD.org Subject: Re: m4 patches for review Message-ID: <20001206062433.D14433@earth.causticlabs.com> References: <20001205170148.A98809@FreeBSD.ORG> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001205170148.A98809@FreeBSD.ORG>; from nra@FreeBSD.ORG on Tue, Dec 05, 2000 at 05:01:48PM -0800 Sender: jedgar@earth.causticlabs.com Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Dec 05, 2000 at 05:01:48PM -0800, Nathan Ahlstrom wrote: > > I have merged in the NetBSD changes to usr.bin/m4 and have > addressed the issues listed on jedgar's web page. Listed below: > > (1) check strdup(3) return values > (2) check malloc(3) return values > (3) check asprintf(3) return values > (4) str(cpy|cat)/sprintf(3) -> strl(cpy|cat)/snprintf/asprintf(3) > (5) mktemp(3) -> mkstemp(3) > (6) [MAXPATHLEN + 1] -> [MAXPATHLEN] The fixes look fine. You might want to coordinate with asmodai (who is working on syncing other BSD changes) to see if he has worked in this area. Also, have you checked for any applicable OpenBSD updates? -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message