From owner-p4-projects@FreeBSD.ORG  Wed May  9 10:01:20 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7903C16A406; Wed,  9 May 2007 10:01:20 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4A4B916A403
	for <perforce@FreeBSD.org>; Wed,  9 May 2007 10:01:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 211AE13C44B
	for <perforce@FreeBSD.org>; Wed,  9 May 2007 10:01:20 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 54F0E46C3B;
	Wed,  9 May 2007 05:35:18 -0400 (EDT)
Date: Wed, 9 May 2007 10:35:18 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Fredrik Lindberg <fli@FreeBSD.org>
In-Reply-To: <4641818B.4030507@FreeBSD.org>
Message-ID: <20070509103404.D71759@fledge.watson.org>
References: <200705082229.l48MTrbh069129@repoman.freebsd.org>
	<20070509070626.GA41419@freebsd.org> <4641818B.4030507@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Roman Divacky <rdivacky@FreeBSD.org>,
	Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 119527 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2007 10:01:20 -0000


On Wed, 9 May 2007, Fredrik Lindberg wrote:

> Roman Divacky wrote:
>> On Tue, May 08, 2007 at 10:29:53PM +0000, Fredrik Lindberg wrote:
>>> http://perforce.freebsd.org/chv.cgi?CH=119527
>>> 
>>> Change 119527 by fli@fli_genesis on 2007/05/08 22:29:14
>>>
>>> 	Add data structures needed by the stack.
>>> 	A Double-linked list and a hash table.
>> 
>> what about sys/queue.h ? it provides various abstract data types including 
>> double-linked list
>
> Yes, I know it does provide that, and I've used it a lot in the past. A 
> while ago I needed a linked list for another project where I needed to be 
> independent of FreeBSD. So I rolled my own (with a similar api) and I've 
> used it ever since. (It can be used both as a stack and queue).
>
> It's not exactly rocket-science and it does increase portability since this 
> is a userland application. If there aren't any major objections or other 
> selling points in favor for sys/queue.h (in a userland application!) I'm 
> just going to leave it as it is.

FYI, slightly stale versions of queue.h are shipped with both Linux and Mac OS 
X, so they are actually relatively portable.  Some of the more recent TAILQ 
macros, etc, aren't available there, so I recently changed from using the 
OS-native queue.h in OpenBSM to a FreeBSD version I ship to use on those 
platforms.

Robert N M Watson
Computer Laboratory
University of Cambridge