From owner-freebsd-acpi@FreeBSD.ORG Sat Jun 26 15:22:05 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A54116A4CE for ; Sat, 26 Jun 2004 15:22:05 +0000 (GMT) Received: from moutvdomng.kundenserver.de (moutvdom.kundenserver.de [212.227.126.249]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB78843D53 for ; Sat, 26 Jun 2004 15:22:04 +0000 (GMT) (envelope-from liamfoy@sepulcrum.org) Received: from [212.227.126.224] (helo=mrvdomng.kundenserver.de) by moutvdomng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BeF06-0006d2-00 for acpi@freebsd.org; Sat, 26 Jun 2004 17:21:54 +0200 Received: from [217.43.76.38] (helo=liamfoy.ath.cx) by mrvdomng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BeF06-0001PD-00 for acpi@freebsd.org; Sat, 26 Jun 2004 17:21:54 +0200 Date: Sat, 26 Jun 2004 16:20:24 +0100 From: "Liam J. Foy" To: acpi@freebsd.org Message-Id: <20040626162024.1ebc2b61.liamfoy@sepulcrum.org> X-Mailer: Sylpheed version 0.9.10 (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: apm -t suggestion X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jun 2004 15:22:05 -0000 Hey guys, I was looking at the following code in acpi_cmbat.c (/usr/src/sys/dev/acpica/): [snip] } else { /* Couldn't find valid rate and full battery time */ bat[i]->min = 0; } 0 is what is eventually returned from apm -t when it couldn't find valid rate or full battery time. I think this should be set to -1 (unknown) instead of 0 as we don't have 0 seconds remaining. Either that or it is mentioned in the man page. What do you guys think ? -- -Liam J. Foy http://liamfoy.kerneled.org