Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jun 2010 20:58:34 +0000 (UTC)
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r209016 - head/sys/net80211
Message-ID:  <201006102058.o5AKwYma063821@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rpaulo
Date: Thu Jun 10 20:58:34 2010
New Revision: 209016
URL: http://svn.freebsd.org/changeset/base/209016

Log:
  Some odd APs send beacons on the same TX queue as non-beacons. This breaks
  802.11 duplicate detection. Upon looking at the standard, we discover
  that 802.11-2007 says:
  "A receiving QoS STA is also required to keep only the most recent
  cache entry per<Address 2, TID, sequence-number>  triple, storing only
  the most recently received fragment number for that triple. A receiving
  STA may omit tuples obtained from broadcast/multicast or ATIM frames
  from the cache."
  
  To fix this, we just disable duplicate detection for multicast/broadcast
  frames.
  
  Reviewed by:	sam
  MFC after:	4 weeks
  Obtained from:	DragonFly

Modified:
  head/sys/net80211/ieee80211_sta.c

Modified: head/sys/net80211/ieee80211_sta.c
==============================================================================
--- head/sys/net80211/ieee80211_sta.c	Thu Jun 10 20:54:53 2010	(r209015)
+++ head/sys/net80211/ieee80211_sta.c	Thu Jun 10 20:58:34 2010	(r209016)
@@ -584,7 +584,7 @@ sta_input(struct ieee80211_node *ni, str
 		}
 		IEEE80211_RSSI_LPF(ni->ni_avgrssi, rssi);
 		ni->ni_noise = nf;
-		if (HAS_SEQ(type)) {
+		if (HAS_SEQ(type) !IEEE80211_IS_MULTICAST(wh->i_addr1)) {
 			uint8_t tid = ieee80211_gettid(wh);
 			if (IEEE80211_QOS_HAS_SEQ(wh) &&
 			    TID_TO_WME_AC(tid) >= WME_AC_VI)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006102058.o5AKwYma063821>