From owner-freebsd-arch@FreeBSD.ORG Wed Oct 24 17:07:57 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F0EBAA8 for ; Wed, 24 Oct 2012 17:07:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id D8D678FC18 for ; Wed, 24 Oct 2012 17:07:56 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id rp8so1449684pbb.13 for ; Wed, 24 Oct 2012 10:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=jlAcRXVk5I0bYuLXV4wl7tL/0eaSQr39YDCdJRuitEQ=; b=cX+LCIBUKSCPXMDHCuY87ESXNi0jAML2BREztegHQ3yVDTLnVhvI4ih0/UU5ePnN7H F074pK+JchJsy6lAPqKgExXlgbo73eu4Pq7lx0QpIbJzlnFJaDWeXu1Zei4ziQGf9e+v aVzG8Sxslx+q5tuJ3UfrB+sdEsN0pcD/k1TVkO/VjTnziuzVZKECpUpjYhLmV4cTf4sL mpgdC85CprNvCo29r5/x7HAVERlhaXKqSarlD+R1zKM7Fs+QNB1tOt/qi8ckP0Wy8j/a 2xUaT0A1Aomcb3yJJxrtUszD0ss7mBoPsFWOdaQhjfoAgXS19zxkjDdakjqmnBVCZLd3 Ej0A== Received: by 10.66.74.40 with SMTP id q8mr45688863pav.29.1351098476212; Wed, 24 Oct 2012 10:07:56 -0700 (PDT) Received: from [10.0.0.63] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPS id ve6sm9712132pbc.58.2012.10.24.10.07.41 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Oct 2012 10:07:52 -0700 (PDT) Sender: Warner Losh Subject: Re: bsd.own.mk - just let WITHOUT_* take precedence Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20121024161844.E8E5658094@chaos.jnpr.net> Date: Wed, 24 Oct 2012 11:07:38 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <18C71853-5C11-4979-BE0D-37E8E4535031@bsdimp.com> References: <20121007001423.9878F58094@chaos.jnpr.net> <20121008154853.GC23400@lor.one-eyed-alien.net> <20121022193903.GA88336@dragon.NUXI.org> <20121024154508.GA93546@lor.one-eyed-alien.net> <20121024161844.E8E5658094@chaos.jnpr.net> To: Simon J. Gerraty X-Mailer: Apple Mail (2.1084) X-Gm-Message-State: ALoCoQktnqq3I/CTGHb0TqPo0sTV8M2a0R6FAaaV8UgielSt3JEnt4ZTBTIArl7spSH+VIc2+jZK Cc: Brooks Davis , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2012 17:07:57 -0000 On Oct 24, 2012, at 10:18 AM, Simon J. Gerraty wrote: >=20 > On Wed, 24 Oct 2012 10:45:08 -0500, Brooks Davis writes: >>> Have you had a chance to review Simon's latest diff? >>=20 >> Yes it's fine if the problem we want to solve is being able to set >> WITH_FOO and WITHOUT_FOO. I'm not sure we don't really just want to = let >> WITH_FOO be overridden by NO_FOO more reliably. >=20 > That can work too, except the comments in bsd.own.mk indicated a = desire > to deprecate NO_* ? NO_* is on its way out, so we should likely just fail for the NO_ = options... In FreeBSD 6.x they were deprecated, so it isn't like there = hasn't been warning. > Since WITH_FOO could be in the environment you cannot simply .undef it > and set WITHOUT_FOO when NO_* is seen - which is the cause of the = errors. > To be consistent, you need to test for NO_* pretty much everywhere = that > I was checking for WITHOUT_* - the two basically become synonymous. > Thus all the logic for setting WITHOUT_* based on NO_* should be = removed? All of the WITH_FOO and WITHOUT_FOO ultimately make it to MK_FOO. = Anything that's still using NO_FOO should be hastened out of the tree = quickly... > Would that be a step forwards or backwards? I think it would be a step forwards. Warner=