Date: Fri, 22 Mar 2019 16:17:41 +0000 (UTC) From: Enji Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r345415 - projects/capsicum-test/contrib/capsicum-test Message-ID: <201903221617.x2MGHfr9013444@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Fri Mar 22 16:17:41 2019 New Revision: 345415 URL: https://svnweb.freebsd.org/changeset/base/345415 Log: Remove `FAIL` macro use for non-x86 architectures when testing `sysarch(2)` First off, `FAIL()` does not support being called in the form noted in the test. Second off, it's better to add a comment, open a bug, etc, instead of causing all test runs to fail on unsupported architectures. Modified: projects/capsicum-test/contrib/capsicum-test/capmode.cc Modified: projects/capsicum-test/contrib/capsicum-test/capmode.cc ============================================================================== --- projects/capsicum-test/contrib/capsicum-test/capmode.cc Fri Mar 22 14:49:22 2019 (r345414) +++ projects/capsicum-test/contrib/capsicum-test/capmode.cc Fri Mar 22 16:17:41 2019 (r345415) @@ -558,8 +558,7 @@ FORK_TEST_F(WithFiles, AllowedMiscSyscalls) { long sysarch_arg = 0; EXPECT_CAPMODE(sysarch(I386_SET_IOPERM, &sysarch_arg)); #else - // TOOD(jra): write a test for arm - FAIL("capmode:no sysarch() test for current architecture"); + // TOOD(jra): write a test for other architectures, like arm #endif #endif }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903221617.x2MGHfr9013444>