From owner-cvs-src@FreeBSD.ORG Sat Feb 18 18:14:51 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC0C316A420; Sat, 18 Feb 2006 18:14:51 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B54F43D45; Sat, 18 Feb 2006 18:14:51 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.240] (ppp-71-139-114-10.dsl.snfc21.pacbell.net [71.139.114.10]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id k1IIEnrs009491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 18 Feb 2006 10:14:50 -0800 Message-ID: <43F76414.4070306@root.org> Date: Sat, 18 Feb 2006 10:14:44 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dag-Erling Smorgrav References: <20060218113528.0A38416A45B@hub.freebsd.org> In-Reply-To: <20060218113528.0A38416A45B@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/powerd powerd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Feb 2006 18:14:51 -0000 Dag-Erling Smorgrav wrote: > des 2006-02-18 11:35:12 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/powerd powerd.c > Log: > Load cpufreq at startup if it isn't there already. > > Revision Changes Path > 1.18 +4 -0 src/usr.sbin/powerd/powerd.c > > > Index: src/usr.sbin/powerd/powerd.c > diff -u src/usr.sbin/powerd/powerd.c:1.17 src/usr.sbin/powerd/powerd.c:1.18 > --- src/usr.sbin/powerd/powerd.c:1.17 Tue Jan 3 21:32:02 2006 > +++ src/usr.sbin/powerd/powerd.c Sat Feb 18 11:35:12 2006 > @@ -433,6 +433,10 @@ > > mode = mode_none; > > + /* Make sure the cpufreq module is loaded */ > + if (!kld_isloaded("cpu/p4tcc") && kld_load("cpufreq") == -1) > + err(1, "failed to load cpufreq module"); > + > /* Poll interval is in units of ms. */ > poll_ival *= 1000; This commit is wrong and should be backed out. 1. On some systems, cpufreq doesn't work when loaded after boot 2. cpufreq is not required for powerd. acpi_perf (part of acpi.ko) is a cpufreq driver and the generic framework is compiled into the kernel. Of course, I would have told you this if you'd emailed me first. -- Nate