From owner-svn-src-head@freebsd.org Thu Jul 18 21:41:18 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 34DB7B23C6; Thu, 18 Jul 2019 21:41:18 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5EEDE72DCB; Thu, 18 Jul 2019 21:41:17 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 4B68F3C0199; Thu, 18 Jul 2019 21:41:15 +0000 (UTC) Date: Thu, 18 Jul 2019 21:41:15 +0000 From: Brooks Davis To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350116 - head/lib/libc/gen Message-ID: <20190718214115.GA42117@spindle.one-eyed-alien.net> References: <201907182133.x6ILXu4k026793@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline In-Reply-To: <201907182133.x6ILXu4k026793@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 5EEDE72DCB X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.19 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-3.56)[ip: (-9.25), ipnet: 199.48.128.0/22(-4.60), asn: 36236(-3.87), country: US(-0.05)]; MX_GOOD(-0.01)[cached: spindle.one-eyed-alien.net]; NEURAL_HAM_SHORT(-0.72)[-0.724,0]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2019 21:41:18 -0000 --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 18, 2019 at 09:33:56PM +0000, Brooks Davis wrote: > Author: brooks > Date: Thu Jul 18 21:33:55 2019 > New Revision: 350116 > URL: https://svnweb.freebsd.org/changeset/base/350116 >=20 > Log: > Document that setmode(3) is not thread safe. > =20 > In some circumstances, setmode(3) may call umask(2) twice to retrieve > the current mode and then restore it. Between calls, the process will > have a umask of 0. This race isn't especially serious, since it only occurs when security.bsd.unprivileged_proc_debug=3D0, but it's probably something to fix. The easiest solution would probably be to implement a getumask() syscall. -- Brooks --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJdMOd6AAoJEKzQXbSebgfARCkIAJ1llteqB1g0WemVZ9X9Sv72 6Nf7wxnTrqtXNrGqyWigDpM1ftyfsLUjvbKtN+oOIuVa3a3FQjkqTEHBpCKPrh8h XIV8v/aXr5nS+xnmd6VT7r0FLnkiKap4R3pZZ2ifcQ7lGcFUB0vU9oHcVtNt+GeL EtD8sF9m8D1MgxR6FtcoEgt2oBMECTdnZDTvjFOX3Xs44Z2qmqZR4n1EVNyTEryf QQmLXoDli6nO4QHPB/qTWfvH1scCV360vv+FQcs+huSWRW7w4hHT8j5G8MHy2pYj 9ATAHX8Q7ynQi6y38e3pREahL1r3A2QZK2F1KeVaTrlG2iq7+porGE8JqH9XVOk= =Vk+s -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--