Date: Tue, 16 Mar 2004 01:00:41 -0800 (PST) From: Slaven Rezic <slaven@rezic.de> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/64317: Update of german/BBBike port Message-ID: <200403160900.i2G90fhu064911@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/64317; it has been noted by GNATS.
From: Slaven Rezic <slaven@rezic.de>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/64317: Update of german/BBBike port
Date: 16 Mar 2004 09:38:22 +0100
Oliver Eikemeier <eikemeier@fillmore-labs.com> writes:
> Slaven Rezic wrote:
>
> > Oliver Eikemeier <eikemeier@fillmore-labs.com> writes:
> >
> >>> .include <bsd.port.mk>
> >>>+
> >>>+.if !defined(PERL_VER) || ${PERL_VER} == 5.005
> >>>+PLIST= ${PKGDIR}/pkg-plist.5005
> >>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{archname}}'
> >>>+.else
> >>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{version}/$$Config{archname}}'
> >>>+.endif
> >>
> >>please check your port with portlint before submitting
> > I do (4 warnings, no error).
>
> It is supposed to say:
> FATAL: Makefile: do not include anything after bsd.port(.post).mk
>
> could you check that you have the latest version of portlint and send me
> the port as a shar if you still get no error?
Hmmm:
9:25 eserte@vran 297 (/tmp/BBBike): port test
===> Validating port with portlint
FATAL: Makefile [12]: use a tab (not space) after a variable name
WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: be sure to include language code "de-" in the module alias name.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
WARN: no CVS directories. Use -N to check a new port.
1 fatal errors and 4 warnings found.
Error validating port
Exit 1
9:26 eserte@vran 298 (/tmp/BBBike): portlint
WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
0 fatal errors and 2 warnings found.
But: ("port test" seems to use -t internally)
9:26 eserte@vran 299 (/tmp/BBBike): portlint -t
FATAL: Makefile [12]: use a tab (not space) after a variable name
WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
1 fatal errors and 2 warnings found.
Exit 1
(which seems somewhat too nit-picky to me)
> >>- never write anything after bsd.port(.post).mk
> > I am open to better solutions. Unfortunately I need to pass the
> > "LOCAL_PERL_ARCH" variable for pkg-plist generation, which in turn
> > needs the current value of some perl Config variables. PERL5 is only
> > defined after including bsd.port.mk, so this part had to go after the
> > include.
>
> If you got a problem like this, *please* don't hack around the port system.
> These things might need a lot of work to clean up. Try asking for help
> on perl@ and ports@.
>
> We have things like PERL_VERSION and PERL_ARCH, so it should be doable.
> If a variable is missing, please post this to ports, so we can fix this.
I used to use PERL_VERSION and PERL_ARCH, but this does not work with
the latest FreeBSD 5.2 builds. It seems to me that a change caused
PERL_ARCH to be something like "mach". BBBike does not install
compiled perl modules to site_perl, but into a private arch directory
with the machine name still included ("lib/i386-freebsd" on older
perls, "lib/5.8.x/i386-freebsd" on current perls).
I do not think that many perl applications use the same installation
scheme, so an extra variable is not the right solution.
> >>- this will break `make describe' on systems without perl installed
> > I can skip this part if perl is missing. How to detect this reliably?
> > By checking the existance of /usr/bin/perl5?
>
> You can't. The system might have no perl installed when the Makefile is
> parsed, but get perl added as dependency (because of USE_PERL5=yes).
> Generally, using != in ports is a bad idea. Really. Please?
>
Well, then I think it's best to generate pkg-plist from script.
Gruss,
Slaven
--
Slaven Rezic - slaven@rezic.de
tkrevdiff - graphical display of diffs between revisions (RCS, CVS or SVN)
http://ptktools.sourceforge.net/#tkrevdiff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403160900.i2G90fhu064911>