From owner-svn-src-head@freebsd.org Tue Apr 19 03:17:49 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9080B138B2; Tue, 19 Apr 2016 03:17:49 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 949291C26; Tue, 19 Apr 2016 03:17:49 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (unknown [10.1.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 2EC13D8CE; Tue, 19 Apr 2016 03:17:48 +0000 (UTC) Subject: Re: svn commit: r298230 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/i386/loader sys/boot/mips/beri/loader sy... To: Devin Teske References: <201604182309.u3IN9MC6047480@repo.freebsd.org> <57157108.6090500@freebsd.org> <84FB3FCC-4779-4ED1-B0A6-142C90D08EEF@freebsd.org> <5715848F.7020805@FreeBSD.org> <57158BF3.3060605@freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Allan Jude Message-ID: <5715A35B.9070602@freebsd.org> Date: Mon, 18 Apr 2016 23:17:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 03:17:49 -0000 On 2016-04-18 22:59, Devin Teske wrote: > >> On Apr 18, 2016, at 6:37 PM, Allan Jude > > wrote: >> >> On 2016-04-18 21:32, Devin Teske wrote: >>> >>>> On Apr 18, 2016, at 6:06 PM, Pedro Giffuni >>> > wrote: >>>> >>>> >>>> >>>> On 04/18/16 19:30, Devin Teske wrote: >>>>> >>>>> >>>>>> On Apr 18, 2016, at 4:43 PM, Allan Jude >>>>> >>>>>> > wrote: >>>>>> >>>>>> On 2016-04-18 19:36, Adrian Chadd wrote: >>>>>>> Someone pointed out how this bloats out memory requirement in loader. >>>>>>> >>>>>>> Did anyone check that? >>>>>>> >>>>>>> -adrian >>>>>>> >>>>>> >>>>>> I tested down to 128mb of ram in QEMU, booted from the installer ISO, >>>>>> did the install, and booted the installed system without issue. >>>>> >>>>> Hmm. Would be nice if we could claim success under 64MB too. >>>>> If you get the chance. >>>>> How low can it go? >>>> >>>> FWIW, The code review comments state: >>>> >>>> >>>> >>>> BTW: as mentioned in very beginning of this project, I'm reserving >>>> fairly large chunk of memory (64MB) for loader and using same amount >>>> for both BIOS/UEFI variants, default in freebsd is 3MB, eventually >>>> this should be reviewed, but currently it will affect very small setups. >>>> >>>> >>>> >>>> I still think it's pretty cool, thanks to everyone involved. >>>> >>> >>> Does anyone know what the original memory reservation amount was >>> before it was upped to 64MB? >>> >> >> It was 3MB >> > > Next [possibly] dumb question(s). > > Is it easily tunable? > If not, why not? > What happens when we want to bump it further in the future? > -- > Devin So, the size of the heap, is a #define in sys/boot/{i386/libi386,pc98/libpc98}/biosmem.c sys/boot/efi/libefi/libefi.c It went from 3MB to 64MB The size of the block cache is set in each of the respective loaders with the call to bcache_init(). The size went from 16kb to 16mb. -- Allan Jude