Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Aug 2005 11:30:24 -0400
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alexander Leidinger <netchild@FreeBSD.org>
Cc:        Sam Leffler <sam@errno.com>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/sound/pcm buffer.c channel.c dsp.c fake.c feeder_fmt.c feeder_rate.c sound.h vchan.c
Message-ID:  <200508011130.26308.jhb@FreeBSD.org>
In-Reply-To: <20050731192113.5746217a@Magellan.Leidinger.net>
References:  <200507311616.j6VGGM4W079108@repoman.freebsd.org> <42ED055E.90803@errno.com> <20050731192113.5746217a@Magellan.Leidinger.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 31 July 2005 01:21 pm, Alexander Leidinger wrote:
> On Sun, 31 Jul 2005 10:07:42 -0700
>
> Sam Leffler <sam@errno.com> wrote:
> > Alexander Leidinger wrote:
> > >           * The arrival of 24/32 also come with a price. Applications
> > >             that can do 24/32bit playback need to be recompiled
> > > (notably mplayer).  Use (recompiled) mplayer to experiment / test /
> > > debug this various format using -af format=fmt. Note that 24bit seeking
> > > in mplayer is a little bit broken, sometimes can cause silence or loud
> > > static noise. Pausing / seeking few times can solve this problem.
> > >             You don't have to rebuild world entirely for this. Simply
> > >             copy /usr/src/sys/sys/soundcard.h to
> > >             /usr/include/sys/soundcard.h would suffice. Few drivers
> > > also need recompilation, and this can be done via
> > >             /usr/src/sys/modules/sound/.
> >
> > Bump FreeBSD version?
>
> I'm not sure (does not knowing it imply that I have to?). soundcard.h
> contains new defines. If an app/port finds those new defines it knows
> that the new feature is there. I think this should cover at least 99%
> of the cases. Does someone think this doesn't cover 100%?
>
> As for runtime issues: /dev/dsp will return an error if an app wants to
> use an usupported format. Every app should be able to handle it (else
> you may have a problem when you get a new soundcard which doesn't
> supports what the previous one supported).

Bump it.  Bumps are cheap and we'd rather have someone test FreeBSD_version 
than play musical guessing games with other less well-defined macros.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508011130.26308.jhb>