Date: Fri, 4 Dec 1998 14:54:58 -0800 (PST) From: Archie Cobbs <archie@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/sys/alpha/alpha db_disasm.c diskslice_machdep.c machdep.c trap.c src/sys/alpha/pci apecs.c cia.c lca.c src/sys/alpha/tc am7990.c espvar.h src/sys/alpha/tlsb tlsb.c src/sys/cam/scsi scsi_all.c scsi_cd.c scsi_ch.c scsi_da.c ... Message-ID: <199812042254.OAA02566@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
archie 1998/12/04 14:54:57 PST
Modified files:
sys/alpha/alpha db_disasm.c diskslice_machdep.c machdep.c
trap.c
sys/alpha/pci apecs.c cia.c lca.c
sys/alpha/tc am7990.c espvar.h
sys/alpha/tlsb tlsb.c
sys/cam/scsi scsi_all.c scsi_cd.c scsi_ch.c scsi_da.c
sys/coda coda_vfsops.c
sys/ddb db_sym.c
sys/dev/advansys advansys.c
sys/dev/aha aha.c
sys/dev/aic7xxx aic7xxx.c
sys/dev/buslogic bt.c
sys/dev/dpt dpt_control.c
sys/dev/en midway.c
sys/dev/hea eni.c eni_if.c
sys/dev/hfa fore_command.c fore_if.c fore_init.c
fore_load.c
sys/gnu/i386/isa/sound awe_wave.c
sys/i386/eisa eisaconf.c
sys/i386/ibcs2 ibcs2_socksys.c ibcs2_stat.c
ibcs2_xenix.c
sys/i386/isa atapi.c cx.c diskslice_machdep.c fd.c
intr_machdep.c loran.c
sys/i386/isa/bs bs_isa.c bsif.c
sys/i386/isa/pcvt pcvt_sup.c
sys/i386/isa/snd ad1848.c sb_dsp.c sound.c
sys/i386/isa/sound ad1848.c gus_wave.c mpu401.c pas2_card.c
pcm86.c pss.c sb16_dsp.c sb_dsp.c
sound_timer.c
sys/i386/linux linux_misc.c
sys/kern imgact_elf.c kern_shutdown.c
kern_sysctl.c subr_autoconf.c
subr_devstat.c subr_diskslice.c
vfs_subr.c
sys/miscfs/kernfs kernfs_vnops.c
sys/miscfs/procfs procfs_map.c procfs_vnops.c
sys/net if.c if_atmsubr.c if_mib.c if_spppsubr.c
if_vlan.c
sys/netatm atm_device.c atm_if.c atm_socket.c
sys/netatm/ipatm ipatm_usrreq.c
sys/netatm/sigpvc sigpvc_if.c
sys/netatm/spans spans_arp.c spans_cls.c spans_if.c
spans_print.c
sys/netatm/uni sscf_uni.c sscop_pdu.c uniarp.c
uniarp_cache.c uniarp_input.c unisig_if.c
unisig_util.c
sys/netinet ip_divert.c ip_fil.c ip_ftp_pxy.c
sys/netipx ipx.c
sys/netnatm natm.c
sys/nfs bootp_subr.c nfs_vfsops.c
sys/pc98/pc98 atcompat_diskslice.c diskslice_machdep.c
sys/pci if_en_pci.c isp_pci.c ncr.c pci_compat.c
pcisupport.c
sys/vm vm_zone.c
Log:
Examine all occurrences of sprintf(), strcat(), and str[n]cpy()
for possible buffer overflow problems. Replaced most sprintf()'s
with snprintf(); for others cases, added terminating NUL bytes where
appropriate, replaced constants like "16" with sizeof(), etc.
These changes include several bug fixes, but most changes are for
maintainability's sake. Any instance where it wasn't "immediately
obvious" that a buffer overflow could not occur was made safer.
Reviewed by: Bruce Evans <bde@zeta.org.au>
Reviewed by: Matthew Dillon <dillon@apollo.backplane.com>
Reviewed by: Mike Spengler <mks@networkcs.com>
Revision Changes Path
1.3 +8 -8 src/sys/alpha/alpha/db_disasm.c
1.6 +2 -2 src/sys/alpha/alpha/diskslice_machdep.c
1.26 +3 -3 src/sys/alpha/alpha/machdep.c
1.8 +2 -2 src/sys/alpha/alpha/trap.c
1.4 +2 -2 src/sys/alpha/pci/apecs.c
1.14 +3 -3 src/sys/alpha/pci/cia.c
1.5 +2 -2 src/sys/alpha/pci/lca.c
1.2 +3 -2 src/sys/alpha/tc/am7990.c
1.2 +2 -3 src/sys/alpha/tc/espvar.h
1.5 +2 -1 src/sys/alpha/tlsb/tlsb.c
1.7 +4 -13 src/sys/cam/scsi/scsi_all.c
1.10 +4 -3 src/sys/cam/scsi/scsi_cd.c
1.7 +3 -2 src/sys/cam/scsi/scsi_ch.c
1.14 +4 -3 src/sys/cam/scsi/scsi_da.c
1.10 +6 -3 src/sys/coda/coda_vfsops.c
1.27 +2 -4 src/sys/ddb/db_sym.c
1.6 +2 -2 src/sys/dev/advansys/advansys.c
1.14 +11 -11 src/sys/dev/aha/aha.c
1.11 +2 -2 src/sys/dev/aic7xxx/aic7xxx.c
1.12 +5 -5 src/sys/dev/buslogic/bt.c
1.10 +3 -2 src/sys/dev/dpt/dpt_control.c
1.11 +4 -4 src/sys/dev/en/midway.c
1.4 +7 -5 src/sys/dev/hea/eni.c
1.3 +4 -3 src/sys/dev/hea/eni_if.c
1.4 +4 -3 src/sys/dev/hfa/fore_command.c
1.3 +4 -3 src/sys/dev/hfa/fore_if.c
1.4 +4 -3 src/sys/dev/hfa/fore_init.c
1.4 +6 -4 src/sys/dev/hfa/fore_load.c
1.5 +1 -1 src/sys/gnu/i386/isa/sound/awe_wave.c
1.36 +3 -3 src/sys/i386/eisa/eisaconf.c
1.10 +2 -2 src/sys/i386/ibcs2/ibcs2_socksys.c
1.8 +10 -11 src/sys/i386/ibcs2/ibcs2_stat.c
1.17 +17 -9 src/sys/i386/ibcs2/ibcs2_xenix.c
1.28 +1 -1 src/sys/i386/isa/atapi.c
1.33 +2 -1 src/sys/i386/isa/cx.c
1.32 +2 -2 src/sys/i386/isa/diskslice_machdep.c
1.125 +3 -3 src/sys/i386/isa/fd.c
1.15 +2 -2 src/sys/i386/isa/intr_machdep.c
1.12 +3 -2 src/sys/i386/isa/loran.c
1.5 +2 -1 src/sys/i386/isa/bs/bs_isa.c
1.8 +1 -1 src/sys/i386/isa/bs/bsif.c
1.13 +1 -1 src/sys/i386/isa/pcvt/pcvt_sup.c
1.17 +4 -4 src/sys/i386/isa/snd/ad1848.c
1.14 +2 -1 src/sys/i386/isa/snd/sb_dsp.c
1.21 +7 -4 src/sys/i386/isa/snd/sound.c
1.25 +6 -4 src/sys/i386/isa/sound/ad1848.c
1.28 +4 -2 src/sys/i386/isa/sound/gus_wave.c
1.19 +4 -2 src/sys/i386/isa/sound/mpu401.c
1.24 +1 -1 src/sys/i386/isa/sound/pas2_card.c
1.5 +3 -2 src/sys/i386/isa/sound/pcm86.c
1.8 +1 -1 src/sys/i386/isa/sound/pss.c
1.28 +2 -2 src/sys/i386/isa/sound/sb16_dsp.c
1.37 +2 -1 src/sys/i386/isa/sound/sb_dsp.c
1.9 +1 -1 src/sys/i386/isa/sound/sound_timer.c
1.46 +13 -7 src/sys/i386/linux/linux_misc.c
1.43 +3 -3 src/sys/kern/imgact_elf.c
1.43 +2 -2 src/sys/kern/kern_shutdown.c
1.79 +2 -2 src/sys/kern/kern_sysctl.c
1.7 +2 -2 src/sys/kern/subr_autoconf.c
1.7 +2 -1 src/sys/kern/subr_devstat.c
1.60 +4 -3 src/sys/kern/subr_diskslice.c
1.174 +2 -2 src/sys/kern/vfs_subr.c
1.36 +4 -4 src/sys/miscfs/kernfs/kernfs_vnops.c
1.18 +3 -2 src/sys/miscfs/procfs/procfs_map.c
1.62 +3 -3 src/sys/miscfs/procfs/procfs_vnops.c
1.63 +5 -3 src/sys/net/if.c
1.8 +4 -2 src/sys/net/if_atmsubr.c
1.6 +3 -2 src/sys/net/if_mib.c
1.46 +6 -6 src/sys/net/if_spppsubr.c
1.4 +3 -3 src/sys/net/if_vlan.c
1.4 +3 -3 src/sys/netatm/atm_device.c
1.3 +12 -11 src/sys/netatm/atm_if.c
1.3 +4 -4 src/sys/netatm/atm_socket.c
1.3 +4 -3 src/sys/netatm/ipatm/ipatm_usrreq.c
1.3 +4 -3 src/sys/netatm/sigpvc/sigpvc_if.c
1.3 +4 -3 src/sys/netatm/spans/spans_arp.c
1.3 +3 -3 src/sys/netatm/spans/spans_cls.c
1.4 +4 -3 src/sys/netatm/spans/spans_if.c
1.4 +50 -36 src/sys/netatm/spans/spans_print.c
1.4 +3 -3 src/sys/netatm/uni/sscf_uni.c
1.3 +4 -3 src/sys/netatm/uni/sscop_pdu.c
1.4 +8 -5 src/sys/netatm/uni/uniarp.c
1.3 +6 -2 src/sys/netatm/uni/uniarp_cache.c
1.3 +4 -3 src/sys/netatm/uni/uniarp_input.c
1.4 +4 -3 src/sys/netatm/uni/unisig_if.c
1.4 +7 -5 src/sys/netatm/uni/unisig_util.c
1.35 +5 -5 src/sys/netinet/ip_divert.c
1.7 +8 -6 src/sys/netinet/ip_fil.c
1.4 +1 -1 src/sys/netinet/ip_ftp_pxy.c
1.13 +5 -5 src/sys/netipx/ipx.c
1.11 +4 -4 src/sys/netnatm/natm.c
1.17 +4 -3 src/sys/nfs/bootp_subr.c
1.79 +3 -3 src/sys/nfs/nfs_vfsops.c
1.13 +2 -2 src/sys/pc98/pc98/atcompat_diskslice.c
1.17 +4 -4 src/sys/pc98/pc98/diskslice_machdep.c
1.4 +1 -1 src/sys/pci/if_en_pci.c
1.9 +2 -2 src/sys/pci/isp_pci.c
1.138 +3 -3 src/sys/pci/ncr.c
1.14 +2 -1 src/sys/pci/pci_compat.c
1.76 +5 -3 src/sys/pci/pcisupport.c
1.24 +4 -3 src/sys/vm/vm_zone.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812042254.OAA02566>