Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Oct 2006 12:41:04 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Cheng-Lung Sung <clsung@freebsd.org>
Cc:        freebsd-hackers@freebsd.org, freebsd-bugs@freebsd.org, freebsd-current@freebsd.org, FreeBSD-gnats-submit@freebsd.org
Subject:   Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
Message-ID:  <20061017123629.X67815@delplex.bde.org>
In-Reply-To: <20061017021407.GA738@FreeBSD.csie.nctu.edu.tw>
References:  <20061015135710.A28897E98D@FreeBSD.csie.nctu.edu.tw> <20061016011559.W61639@delplex.bde.org> <200610161431.25228.jhb@freebsd.org> <20061017021407.GA738@FreeBSD.csie.nctu.edu.tw>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 17 Oct 2006, Cheng-Lung Sung wrote:

> On Mon, Oct 16, 2006 at 02:31:24PM -0400, John Baldwin wrote:
>> Is this better?
>> ...
>    Thanks, I didn't go through the whole sem.h.
>    Also, it seems we should put these parts before 'sturct semid_ds'.
>    or say, after we include sys/ipc.h (which include sys/_types.h)

Yes, that is especially needed for time_t, since it is the only one of
the typedef'ed types used early in sys/sem.h.  The others might be needed
later when the non-typedefed types are cleaned up.  (sys/ipc.h needs
cleaning up more.  It still spells uid_t as "unsigned short", but uids
aren't that short...)

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061017123629.X67815>