Date: Thu, 21 Oct 2010 12:08:12 -0700 From: Xin LI <delphij@delphij.net> To: John Baldwin <jhb@FreeBSD.ORG> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI <delphij@FreeBSD.ORG> Subject: Re: svn commit: r214125 - head/sys/kern Message-ID: <4CC08F9C.5010804@delphij.net> In-Reply-To: <201010210746.41227.jhb@freebsd.org> References: <201010210857.o9L8vPVQ084307@svn.freebsd.org> <201010210746.41227.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------080107040006070001050407 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/21/10 04:46, John Baldwin wrote: > On Thursday, October 21, 2010 4:57:25 am Xin LI wrote: >> Author: delphij >> Date: Thu Oct 21 08:57:25 2010 >> New Revision: 214125 >> URL: http://svn.freebsd.org/changeset/base/214125 >> >> Log: >> In syscall_module_handler(): all switch branches return, remove >> unreached code as pointed out in a Chinese forum [1]. >> >> [1] http://www.freebsdchina.org/forum/viewtopic.php?t=50619 >> >> Pointed out by: btw616 <btw s qq com> >> MFC after: 1 month > > I think this exposes a bug though in that the default case doesn't pass > through to chainevh. The default case should look more like the removed code > (except returning EOPNOTSUPP instead of 0 if there is no chainevh). Hmm... It sounds reasonable in theory (so that modules can handle events other than MOD_LOAD/UNLOAD) at least, while I don't think it's really being used anywhere. Will the attached patch look reasonable? (If data->chainevh is NULL then operation is not supported, if not then delegate to the module). Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQEcBAEBCAAGBQJMwI+cAAoJEATO+BI/yjfBADUH/21dtdgSziij8hNi8ef5xOZH QMbGRoHNUREVfuAnAevGNDotSonaRv+VEs5k9raRqqYFdtst6KzNjVQuumJsskmq +6j7rSPXQvAmgEf6JgEZmjU/WzRbs4lozMjUOx0TW6ZSTtiXq+PSvmMe7q9iydiT YKOj8E/itVFjKY2qMGNkAQ893qzIWvptDR9QGJP+m+8usTnYvAlk8vQw3XhfR/ws MNE726rDNwD2sblH2IZI0dt/xy8i6mD5Ef1aM4KEkeussBjGlLAktSS6qFB71lql JpGC9SCelhJRci6gLTvAbAyIe9hoFf8C7P+AbFXgVNMQxYWIHSzQr5BktwxSpc0= =C6jc -----END PGP SIGNATURE----- --------------080107040006070001050407 Content-Type: text/plain; name="kern_syscalls.c.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kern_syscalls.c.diff" SW5kZXg6IHN5cy9rZXJuL2tlcm5fc3lzY2FsbHMuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMv a2Vybi9rZXJuX3N5c2NhbGxzLmMJKHJldmlzaW9uIDIxNDE0NikKKysrIHN5cy9rZXJuL2tl cm5fc3lzY2FsbHMuYwkod29ya2luZyBjb3B5KQpAQCAtMTgxLDcgKzE4MSw5IEBACiAJCWVy cm9yID0gc3lzY2FsbF9kZXJlZ2lzdGVyKGRhdGEtPm9mZnNldCwgJmRhdGEtPm9sZF9zeXNl bnQpOwogCQlyZXR1cm4gKGVycm9yKTsKIAlkZWZhdWx0OgotCQlyZXR1cm4gRU9QTk9UU1VQ UDsKKwkJaWYgKGRhdGEtPmNoYWluZXZoKQorCQkJcmV0dXJuIChkYXRhLT5jaGFpbmV2aCht b2QsIHdoYXQsIGRhdGEtPmNoYWluYXJnKSk7CisJCXJldHVybiAoRU9QTk9UU1VQUCk7CiAJ fQogCiAJLyogTk9UUkVBQ0hFRCAqLwo= --------------080107040006070001050407--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CC08F9C.5010804>