From owner-cvs-all@FreeBSD.ORG Thu Oct 19 01:04:54 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B56A416A416; Thu, 19 Oct 2006 01:04:54 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from pil.idi.ntnu.no (pil.idi.ntnu.no [129.241.107.93]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2E1843D5E; Thu, 19 Oct 2006 01:04:53 +0000 (GMT) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from cvsup.no.freebsd.org (c2h5oh.idi.ntnu.no [129.241.103.69]) by pil.idi.ntnu.no (8.13.6/8.13.1) with ESMTP id k9J14pMY026540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 19 Oct 2006 03:04:51 +0200 (MEST) Received: from localhost (localhost [127.0.0.1]) by cvsup.no.freebsd.org (8.13.4/8.13.4) with ESMTP id k9J14oUd045614; Thu, 19 Oct 2006 01:04:50 GMT (envelope-from Tor.Egge@cvsup.no.freebsd.org) Date: Thu, 19 Oct 2006 01:04:35 +0000 (UTC) Message-Id: <20061019.010435.41670238.Tor.Egge@cvsup.no.freebsd.org> To: keramida@freebsd.org From: Tor Egge In-Reply-To: <20061019000424.GA1262@gothmog.pc> References: <20061015091459.V72308@godot.imp.ch> <20061018234916.GA1711@gothmog.pc> <20061019000424.GA1262@gothmog.pc> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned-By: mimedefang.idi.ntnu.no, using CLAMD X-SMTP-From: Sender=, Relay/Client=c2h5oh.idi.ntnu.no [129.241.103.69], EHLO=cvsup.no.freebsd.org X-Scanned-By: MIMEDefang 2.48 on 129.241.107.38 X-Scanned-By: mimedefang.idi.ntnu.no, using MIMEDefang 2.48 with local filter 16.42-idi X-Filter-Time: 1 seconds Cc: cvs-src@freebsd.org, mb@imp.ch, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_conf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2006 01:04:54 -0000 > FWIW, reverting revision 1.199 of kern_conf.c locally fixes the > unkillable xterms, stuck in "devdrn", problem. destroy_devl() is only stuck in "devdrn" if a thread has called dev_refthread() but not yet called dev_relthread(). If that thread doesn't sleep forever then it might write to freed memory on a system where revision 1.199 of kern_conf is reverted, cf. . Pseudo ttys need a purge method since there might be races associated with trying to wake sleeping threads before calling destroy_dev() where a new thread can go to sleep at the wrong moment. A related race is devfs_fp_check() versus devfs_reclaim(), allowing for dev_refthread() to be called with a pointer to freed memory. - Tor Egge