From owner-freebsd-current@FreeBSD.ORG  Mon Jun 29 14:18:14 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D1CA1065673
	for <freebsd-current@freebsd.org>; Mon, 29 Jun 2009 14:18:14 +0000 (UTC)
	(envelope-from mav@FreeBSD.org)
Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C4368FC1E
	for <freebsd-current@freebsd.org>; Mon, 29 Jun 2009 14:18:13 +0000 (UTC)
	(envelope-from mav@FreeBSD.org)
Received: from [212.86.226.226] (account mav@alkar.net HELO
	mavbook.mavhome.dp.ua)
	by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9)
	with ESMTPSA id 247075567; Mon, 29 Jun 2009 17:18:09 +0300
Message-ID: <4A48CD19.8080606@FreeBSD.org>
Date: Mon, 29 Jun 2009 17:18:01 +0300
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090405)
MIME-Version: 1.0
To: Kamigishi Rei <spambox@haruhiism.net>
References: <1246206181.00132972.1246192801@10.7.7.3>	<1246206186.00132982.1246194002@10.7.7.3>	<1246209783.00133001.1246197001@10.7.7.3>	<1246260183.00133237.1246247402@10.7.7.3>	<4A48798A.5070604@FreeBSD.org>
	<4A487BF7.8060103@haruhiism.net> <4A48922D.5090507@FreeBSD.org>
	<4A48C0BC.3030104@haruhiism.net>
In-Reply-To: <4A48C0BC.3030104@haruhiism.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: RFC: ATA to CAM integration patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2009 14:18:14 -0000

Kamigishi Rei wrote:
> Alexander Motin wrote:
>> Sorry, my fault, it is the different bug, due to disabled invariants I 
>> have missed two locking issues. Here is regenerated patch, including 
>> this fix and all previous fixes and improvements:
>> http://people.freebsd.org/~mav/cam-ata.20090629.patch
> 
> OK, a question about the module: sometimes I'm getting loads (20+) of 
> messages like
> 
> ahcich1: ALL SLOTS BUSY!
> 
> Is it purely informational or does it indicate a problem? (I'm using 
> Intel Q35+ICH9 in AHCI mode.)

It is bad. It must never happen. It means that driver got more commands 
then it has empty slots available. Results can be unpredictable.

How have you manage it? Were there any other messages around?

> P.S. Could you please change "Native Command Queueing Enabled" to 
> "Native Command Queueing enabled" ;) just for better looks, as many of 
> FreeBSD's kernel messages lack proper capitalization and such. Thanks ;)

Better looks - better works! :) Done.

-- 
Alexander Motin