Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Dec 2015 23:22:42 +0200
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r291909 - head/sys/sys
Message-ID:  <20151206212242.GI2202@kib.kiev.ua>
In-Reply-To: <201512062116.tB6LG1Cc058770@repo.freebsd.org>
References:  <201512062116.tB6LG1Cc058770@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 06, 2015 at 09:16:01PM +0000, Ed Maste wrote:
> Author: emaste
> Date: Sun Dec  6 21:16:01 2015
> New Revision: 291909
> URL: https://svnweb.freebsd.org/changeset/base/291909
> 
> Log:
>   Add definitions for ELF note types used in executables
>   
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/sys/sys/elf_common.h
> 
> Modified: head/sys/sys/elf_common.h
> ==============================================================================
> --- head/sys/sys/elf_common.h	Sun Dec  6 21:07:33 2015	(r291908)
> +++ head/sys/sys/elf_common.h	Sun Dec  6 21:16:01 2015	(r291909)
> @@ -727,6 +727,11 @@ typedef struct {
>  #define	LL_DELAY_LOAD		0x10
>  #define	LL_DELTA		0x20
>  
> +/* Values for n_type used in executables. */
> +#define	NT_FREEBSD_ABI_TAG	1
> +#define	NT_FREEBSD_NOINIT_TAG	2
> +#define	NT_FREEBSD_ARCH_TAG	3
> +
>  /* Values for n_type.  Used in core files. */
>  #define	NT_PRSTATUS	1	/* Process status. */
>  #define	NT_FPREGSET	2	/* Floating point registers. */
Do you plan to make a pass over the tree, switching uses of *_NOTETYPE
to NT_FREEBSD_*_TAG ?  See lib/csu/common/notes.h.

Also, sys/kern/imgact_elf.c would benefit from use of NT_FREEBSD_ABI_TAG
instead of magic '1' in brandnotes.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151206212242.GI2202>